BUG: Fix .loc/.iloc/.at/iat cast unexpectedly with object dtype #49306
Conversation
| @@ -973,8 +973,8 @@ def setitem(self, indexer, value) -> Block: | |||
|
|
|||
| # length checking | |||
| check_setitem_lengths(indexer, value, values) | |||
|
|
|||
| value = extract_array(value, extract_numpy=True) | |||
| if self.dtype != _dtype_obj: | |||
There was a problem hiding this comment.
Do we even need the extract_array call at all? I think the point of it is to explicitly convert a Series / Index to an object-dtype ndarray. If that's the case you are trying to avoid I don't think even need the condition here
There was a problem hiding this comment.
I think we need the extract_array call, otherwise, some tests in the indexing folder will not pass.
There was a problem hiding this comment.
Interesting - do you know what the failures are? Are they Index-related?
There was a problem hiding this comment.
definitely add a comment here pointing back to the PR/issue
might be np_can_hold_element assumes extract_array has been called, don't quote me on that.
There was a problem hiding this comment.
@xr-chen can you confirm what @jbrockmendel is saying? I'm not sure yet if this is worth doing as is or if we should try to solve the issue comprehensively
There was a problem hiding this comment.
@WillAyd I think he was right, he definitely knows extract_array and np_can_hold_element better than me. Do you have any plans on fixing it comprehensively?
WillAyd
added
the
Indexing
Co-authored-by: William Ayd <william.ayd@icloud.com>
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
update branch obj
|
Thanks for reopening, I have merged in the main branch. Any suggestions for this pull request? |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
.loc/.iloc/.at/iatsetitem coerces a pd.Series to np.ndarray with object dtype #48933 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.