[Tests] New iteration of removing $this occurrences in future static data providers
#48988
+333
−293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jan 16, 2023
OskarStark
reviewed
Jan 16, 2023
| } | ||
|
|
||
| public function provideMissingStrategies() | ||
| { | ||
| yield from $this->provideStrategies('non-existent-file.json'); | ||
| yield from static::provideStrategies('non-existent-file.json'); | ||
| } | ||
|
|
||
| public function provideStrategies(string $manifestPath) |
There was a problem hiding this comment.
Suggested change
| public function provideStrategies(string $manifestPath) | |
| public static function provideStrategies(string $manifestPath) |
?
There was a problem hiding this comment.
The other PR will only change this to static automatically, if it is directly used as a dataProvider somewhere, is that the case?
There was a problem hiding this comment.
I would say yes but isn't it a BC break to do so on a public method?
There was a problem hiding this comment.
tests are not covered by the BC policy
There was a problem hiding this comment.
/Test/ directory is covered by BC, while /Tests/ not
There was a problem hiding this comment.
Oh I wasn't aware of this detail, thank you! Updated the PR
alexandre-daubois
force-pushed
the
fix/remove-this-data-provider-2
branch
2 times, most recently
from
4291a41
to
e9b5e37
Compare
|
Can you merge this one and #49054 please? |
…c data providers
alexandre-daubois
force-pushed
the
fix/remove-this-data-provider-2
branch
from
e9b5e37
to
1386ac2
Compare
|
That's merged |
|
I think this can be merged @nicolas-grekas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Follow-up of #48980