[Serializer] Prevent GetSetMethodNormalizer from creating invalid magic method call
#48233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
GetSetMethodNormalizer from creating invalid magic method call
OskarStark
reviewed
Nov 18, 2022
src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php
Outdated
Show resolved
Hide resolved
klaussilveira
force-pushed
the
serializer-callable-fix
branch
from
b9f462a
to
11f49bf
Compare
|
Should the |
|
@xabbuh denormalization does not seem to be affected. |
Doe we have a test case for this? Otherwise it could be helpful to add one in this PR |
klaussilveira
force-pushed
the
serializer-callable-fix
branch
from
11f49bf
to
4a34485
Compare
|
I was wrong! Good catch @xabbuh. Managed to reproduce it, but had to take a different approach: |
nicolas-grekas
requested review from
lyrixx,
yceruto,
wouterj,
chalasr and
xabbuh
as code owners
nicolas-grekas
force-pushed
the
serializer-callable-fix
branch
from
4a34485
to
adbb96f
Compare
nicolas-grekas
force-pushed
the
serializer-callable-fix
branch
from
adbb96f
to
d4e1edd
Compare
|
Thank you @klaussilveira. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When serializing an object that has an
isserfor a property, but not agetter, and the object happens to have a__callmagic method, theGetSetMethodNormalizerwill attempt to call the magic method with the attribute. This may cause unexpected behavior, or, a fatal. It depends on the__callimplementation.This undefined behavior is caused by the use of
is_callableongetAttributeValue, which will return true since there is a__callimplementation. The correct behavior can be achieved by usingmethod_existsinstead. A test case has been added that illustrates the issue.