Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DoctrineBridge] Skip resolving entities when the corresponding request attribute is already an object #48489

Merged
merged 1 commit into from Dec 8, 2022
Merged

[DoctrineBridge] Skip resolving entities when the corresponding request attribute is already an object #48489

merged 1 commit into from Dec 8, 2022

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48433
License MIT
Doc PR -

@carsonbot carsonbot added this to the 6.3 milestone Dec 5, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.3 to 6.2 December 5, 2022 17:56
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.2 Dec 5, 2022
@symfony symfony deleted a comment from carsonbot Dec 5, 2022
@nicolas-grekas nicolas-grekas mentioned this pull request Dec 5, 2022
Closed
@nicolas-grekas nicolas-grekas changed the title [DoctrineBridge] Skip throwing when entity is not found and no attribute explicitly asks for it [DoctrineBridge] Skip resolving entities when the corresponding request attribute is already an object Dec 6, 2022
chalasr
chalasr approved these changes Dec 6, 2022
View changes
fabpot
fabpot approved these changes Dec 8, 2022
View changes
@fabpot
Copy link
Member

fabpot commented Dec 8, 2022

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 0d95f41 into symfony:6.2 Dec 8, 2022
8 of 9 checks passed
@nicolas-grekas nicolas-grekas deleted the entity-value-resolver branch December 8, 2022 11:09
@xabbuh xabbuh mentioned this pull request Dec 12, 2022
Closed
@nicolas-grekas nicolas-grekas mentioned this pull request Dec 14, 2022
Closed
@fabpot fabpot mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot

@chalasr chalasr

Assignees
No one assigned
Labels
Bug DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
6.2
4 participants
@nicolas-grekas @fabpot @chalasr @carsonbot