Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PY_CHECK_SQLITE_FUNC() adds -lsqlite3 multiple times #94165

Open
tiran opened this issue Jun 23, 2022 · 1 comment · May be fixed by #94198
Open

PY_CHECK_SQLITE_FUNC() adds -lsqlite3 multiple times #94165

tiran opened this issue Jun 23, 2022 · 1 comment · May be fixed by #94198
Assignees
@erlend-aasland
Labels
3.11 3.12 build type-bug

Comments

@tiran
Copy link
Member

@tiran tiran commented Jun 23, 2022

Bug report

The configure.ac macro PY_CHECK_SQLITE_FUNC keeps on adding -lsqlite3 over and over again. This seems to cause some problems on Emscripten with a static libsqlite3.a file.

configure:12473: checking for sqlite3.h
configure:12473: result: yes
configure:12496: gcc -c   -I$(srcdir)/Modules/_sqlite  conftest.c >&5
configure:12496: $? = 0
configure:12500: checking for sqlite3_bind_double in -lsqlite3
configure:12525: gcc -o conftest   -I$(srcdir)/Modules/_sqlite  -lsqlite3   conftest.c -lsqlite3  -ldl  >&5
configure:12525: $? = 0
configure:12534: result: yes
configure:12551: checking for sqlite3_column_decltype in -lsqlite3
configure:12576: gcc -o conftest   -I$(srcdir)/Modules/_sqlite  -lsqlite3   conftest.c -lsqlite3  -lsqlite3 -ldl  >&5
configure:12576: $? = 0
configure:12585: result: yes
...
configure:12806: checking for sqlite3_result_double in -lsqlite3
configure:12831: gcc -o conftest   -I$(srcdir)/Modules/_sqlite  -lsqlite3   conftest.c -lsqlite3  -lsqlite3 -lsqlite3 -lsqlite3 -lsqlite3 -lsqlite3 -lsqlite3 -ldl  >&5

Erlend is going to look into the problem.
@tiran tiran added type-bug build 3.11 3.12 labels Jun 23, 2022
@tiran
Copy link
Member Author

@tiran tiran commented Jun 23, 2022

AC_CHECK_LIB([sqlite3], ...) adds -lsqlite3 a second time after it has been added by LDFLAGS="$LIBSQLITE3_LIBS $LDFLAGS"

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jun 24, 2022
@erlend-aasland
pythongh-94165: Prevent PY_CHECK_SQLITE_FUNC from accumulating linker…
f6c2453 
… options
@erlend-aasland erlend-aasland linked a pull request Jun 24, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
3.11 3.12 build type-bug
Projects
sqlite3 issues
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-94165: Prevent PY_CHECK_SQLITE_FUNC from accumulating linker options erlend-aasland/cpython
2 participants
@tiran @erlend-aasland