gh-101035: Check `fs.st_mtime` before use. #101036

EvanLai88 · 2023-01-14T15:52:05Z

datetime.datetime.fromtimestamp() will raise OSError on win32 when timestamp is less then -43200.
If so, use timestamp from time.time().

Issue: OSError: [Errno 22] Invalid argument when serving files with last modified time before 1969-12-31 12:00 UTC on windows #101035

datetime.datetime.fromtimestamp() will raise `OSError` on `win32` when timestamp is less then `-43200`. If so, use timestamp from `time.time()`.

bedevere-bot · 2023-01-14T15:52:11Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

cpython-cla-bot · 2023-01-14T15:52:29Z

All commit authors signed the Contributor License Agreement.

Lib/http/server.py

…ver-last-modified

…88/cpython into httpserver-last-modified

check fs.st_mtime before use

724a2ea

datetime.datetime.fromtimestamp() will raise `OSError` on `win32` when timestamp is less then `-43200`. If so, use timestamp from `time.time()`.

bedevere-bot added the awaiting review label Jan 14, 2023

bedevere-bot mentioned this pull request Jan 14, 2023

OSError: [Errno 22] Invalid argument when serving files with last modified time before 1969-12-31 12:00 UTC on windows #101035

Open

📜🤖 Added by blurb_it.

72ea556

eryksun reviewed Jan 14, 2023

View changes

Lib/http/server.py Outdated Show resolved Hide resolved

EvanLai88 and others added 4 commits Jan 14, 2023

Merge branch 'main' of https://github.com/python/cpython into httpser…

0e6c2eb

…ver-last-modified

Merge branch 'httpserver-last-modified' of https://github.com/EvanLai…

d688026

…88/cpython into httpserver-last-modified

Use 0 instead of time.time()

3afcad9

Merge branch 'main' into httpserver-last-modified

2da34d4

gh-101035: Check `fs.st_mtime` before use. #101036

gh-101035: Check `fs.st_mtime` before use. #101036

EvanLai88 commented Jan 14, 2023 •

edited by bedevere-bot

bedevere-bot commented Jan 14, 2023

cpython-cla-bot bot commented Jan 14, 2023 •

edited

gh-101035: Check fs.st_mtime before use. #101036

Are you sure you want to change the base?

gh-101035: Check fs.st_mtime before use. #101036

Conversation

EvanLai88 commented Jan 14, 2023 • edited by bedevere-bot

bedevere-bot commented Jan 14, 2023

cpython-cla-bot bot commented Jan 14, 2023 • edited

gh-101035: Check `fs.st_mtime` before use. #101036

gh-101035: Check `fs.st_mtime` before use. #101036

EvanLai88 commented Jan 14, 2023 •

edited by bedevere-bot

cpython-cla-bot bot commented Jan 14, 2023 •

edited