[Messenger] Mention the transport which failed during the setup command #49044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features / 5.4, 6.0, 6.1, or 6.2 for bug fixes". Cheers! Carsonbot |
thePanz
force-pushed
the
messenger-mention-transport-failing-to-setup
branch
3 times, most recently
from
4f96fc4
to
63eed29
Compare
thePanz
requested review from
wouterj,
chalasr,
dunglas and
OskarStark
as code owners
OskarStark
reviewed
Jan 20, 2023
src/Symfony/Component/Messenger/Tests/Command/SetupTransportsCommandTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jan 20, 2023
thePanz
force-pushed
the
messenger-mention-transport-failing-to-setup
branch
from
63eed29
to
d6a5ac3
Compare
thePanz
requested review from
OskarStark
and removed request for
dunglas,
lyrixx,
wouterj,
xabbuh,
yceruto and
chalasr
thePanz
force-pushed
the
messenger-mention-transport-failing-to-setup
branch
from
d6a5ac3
to
634a79d
Compare
OK, thanks for clarifying |
thePanz
force-pushed
the
messenger-mention-transport-failing-to-setup
branch
2 times, most recently
from
078d3d7
to
b5f2b3f
Compare
|
@OskarStark thanks for reviewing. I guess the failed CIs are not due to this PR (pSaml and appveyor reports errors not related to the messenger component) |
nicolas-grekas
reviewed
Jan 26, 2023
src/Symfony/Component/Messenger/Command/SetupTransportsCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/SetupTransportsCommand.php
Outdated
Show resolved
Hide resolved
thePanz
force-pushed
the
messenger-mention-transport-failing-to-setup
branch
from
b5f2b3f
to
00afef1
Compare
The transport name can help to further investigate the underlying reasons of the failure
thePanz
force-pushed
the
messenger-mention-transport-failing-to-setup
branch
from
00afef1
to
49c0af9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The transport name can help to further investigate the underlying reasons of the failure
I am not sure if this can be labelled as a new feature, but the addition from this PR can help to further investigate errors while setting up an application's transports.
At the moment, if an error occurs while setting up a transport just the exception is thrown, with no context on which transport was being setup.