Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license years (last time) #49088

Merged
merged 2 commits into from Feb 2, 2023
Merged

Update license years (last time) #49088

merged 2 commits into from Feb 2, 2023

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jan 24, 2023

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a

@carsonbot carsonbot added this to the 5.4 milestone Jan 24, 2023
stof
stof approved these changes Jan 24, 2023
View changes
xabbuh
xabbuh approved these changes Jan 26, 2023
View changes
wouterj
wouterj approved these changes Jan 27, 2023
View changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another approval, in case this is a roulet game where the last remaining core team member that doesn't approve has to do the merge and merge-up of this one 😉

lyrixx
lyrixx approved these changes Jan 30, 2023
View changes
Copy link
Member

@lyrixx lyrixx left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the last one 😅!

@derrabus
Copy link
Member

I wonder if this is going to pass. Looks like a close vote.

fancyweb
fancyweb approved these changes Jan 30, 2023
View changes
Copy link
Contributor

@fancyweb fancyweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🧹

@alexislefebvre
Copy link
Contributor

It looks like that the “Package / Verify” job on the CI needs a year number:

symfony/doctrine-bridge
Verifying new package
First line of the license file is wrong. Maybe it is the wrong year?

@stof
Copy link
Member

stof commented Jan 30, 2023

.github/workflows/package-tests.yml should be updated to change the check being done.

@GromNaN GromNaN mentioned this pull request Jan 31, 2023
Merged
@fabpot fabpot merged commit b92dc2c into symfony:5.4 Feb 2, 2023
8 of 12 checks passed
@fabpot fabpot deleted the copyright-year-forever branch February 2, 2023 07:33
@stof
Copy link
Member

stof commented Feb 2, 2023

@fabpot the fix for the CI check is wrong, making the CI red

@xabbuh
Copy link
Member

xabbuh commented Feb 3, 2023

@stof IIRC this step is usually only applied when a new license file is added for which the check is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas

@lyrixx lyrixx

@stof stof

@wouterj wouterj

@welcoMattic welcoMattic

@OskarStark OskarStark

@derrabus derrabus

@xabbuh xabbuh

@yceruto yceruto

@fancyweb fancyweb

@chalasr chalasr

@jderusse jderusse

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet