Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Validator] Avoid TypeError and improve DX when null groups #49137

Open
wants to merge 1 commit into
base: 5.4
Choose a base branch
from
Open

[Validator] Avoid TypeError and improve DX when null groups #49137

wants to merge 1 commit into from
+15 −0

Conversation

alamirault
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

Improve DX when we pass null value in array of groups

$this->validate($entity, null, ['Group 1', null])

Before this PR
TypeError: Symfony\Component\Validator\Context\ExecutionContext::isGroupValidated(): Argument #2 ($groupHash) must be of type string, null given,

@carsonbot carsonbot added this to the 5.4 milestone Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alamirault @carsonbot