Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. #101412

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. #101412

wants to merge 4 commits into from
+142 −189

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jan 29, 2023 •
edited

This should be the last sweep of the error handling code.

Also fixes bugs in NEW_JUMP_TARGET_LABEL, USE_LABEL which returned 0 for error, and in compiler_lambda which did the same in one place.

@iritkatriel iritkatriel requested a review from markshannon as a code owner Jan 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 29, 2023
Open
corona10
corona10 approved these changes Jan 30, 2023
View changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 30, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 4883b47 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 30, 2023
@iritkatriel iritkatriel changed the title gh-99955: used SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. gh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@markshannon markshannon

Assignees
No one assigned
Labels
awaiting merge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iritkatriel @bedevere-bot @corona10