Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip parsing JSDoc in .ts files #52466

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Skip parsing JSDoc in .ts files #52466

wants to merge 4 commits into from
+12 −1

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Jan 27, 2023 •
edited

Just an experiment for now. JSDoc is still parsed

  1. in tsserver
  2. in .js files
  3. when the comment contains @link or @see

An alternative would make the parser parse lazily, and instead have the checker skip checking in the above conditions. After thinking about it, I'm not sure that's much better.

@sandersn
Skip JSDoc in .ts files
5d585f6 
Just an experiment for now. Current test failures:

- all fourslash tests of jsdoc fail; the parser should produce jsdoc
  for tsserver.
- Spurious unused-type errors because `@link` isn't parsed and treated
  as a usage.
- ohhh no, `@this` is mistakenly interpreted in .ts files:
  thisInFunctionCall.
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 27, 2023
@sandersn
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023 •
edited

Heya @sandersn, I've started to run the perf test suite on this PR at 5d585f6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52466
Metric main 52466 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 359,849k (± 0.01%) 348,991k (± 0.01%) 🟩-10,857k (- 3.02%) 348,970k 349,021k
Parse Time 3.93s (± 0.86%) 3.18s (± 0.62%) 🟩-0.75s (-19.07%) 3.15s 3.20s
Bind Time 1.17s (± 0.47%) 1.13s (± 0.91%) 🟩-0.04s (- 3.55%) 1.12s 1.15s
Check Time 8.66s (± 0.52%) 8.57s (± 0.27%) -0.09s (- 1.04%) 8.54s 8.60s
Emit Time 7.63s (± 0.46%) 7.83s (± 0.78%) +0.20s (+ 2.62%) 7.77s 7.93s
Total Time 21.39s (± 0.36%) 20.71s (± 0.33%) 🟩-0.68s (- 3.18%) 20.64s 20.83s
Compiler-Unions - node (v18.10.0, x64)
Memory used 192,550k (± 0.07%) 191,435k (± 1.20%) -1,114k (- 0.58%) 190,449k 196,140k
Parse Time 1.65s (± 2.58%) 1.44s (± 2.56%) 🟩-0.21s (-12.90%) 1.38s 1.47s
Bind Time 0.80s (± 1.30%) 0.75s (± 0.68%) 🟩-0.04s (- 5.44%) 0.75s 0.76s
Check Time 9.64s (± 1.06%) 9.62s (± 0.67%) -0.02s (- 0.22%) 9.52s 9.71s
Emit Time 2.87s (± 4.51%) 2.81s (± 0.57%) -0.06s (- 2.21%) 2.78s 2.82s
Total Time 14.96s (± 0.95%) 14.62s (± 0.62%) -0.34s (- 2.28%) 14.51s 14.76s
Monaco - node (v18.10.0, x64)
Memory used 343,992k (± 0.01%) 342,535k (± 0.01%) -1,457k (- 0.42%) 342,501k 342,585k
Parse Time 2.94s (± 0.82%) 2.85s (± 0.41%) 🟩-0.09s (- 3.17%) 2.84s 2.87s
Bind Time 1.03s (± 1.06%) 1.01s (± 0.51%) -0.02s (- 1.62%) 1.01s 1.02s
Check Time 7.03s (± 0.57%) 7.00s (± 0.48%) -0.04s (- 0.50%) 6.96s 7.06s
Emit Time 4.31s (± 0.41%) 4.31s (± 0.62%) -0.00s (- 0.00%) 4.29s 4.36s
Total Time 15.33s (± 0.41%) 15.17s (± 0.31%) -0.16s (- 1.02%) 15.11s 15.22s
TFS - node (v18.10.0, x64)
Memory used 300,372k (± 0.01%) 300,468k (± 0.01%) +96k (+ 0.03%) 300,450k 300,507k
Parse Time 2.25s (± 1.08%) 2.26s (± 0.93%) +0.01s (+ 0.59%) 2.23s 2.28s
Bind Time 1.17s (± 0.54%) 0.95s (± 0.67%) 🟩-0.22s (-18.80%) 0.94s 0.96s
Check Time 6.51s (± 0.43%) 6.83s (± 0.48%) +0.32s (+ 4.84%) 6.78s 6.88s
Emit Time 3.92s (± 0.39%) 3.93s (± 1.01%) +0.01s (+ 0.34%) 3.88s 3.99s
Total Time 13.84s (± 0.33%) 13.96s (± 0.36%) +0.12s (+ 0.87%) 13.92s 14.06s
material-ui - node (v18.10.0, x64)
Memory used 476,716k (± 0.01%) 462,848k (± 0.01%) -13,868k (- 2.91%) 462,785k 462,901k
Parse Time 3.57s (± 0.35%) 2.60s (± 0.57%) 🟩-0.97s (-27.22%) 2.58s 2.62s
Bind Time 0.97s (± 0.65%) 1.10s (± 0.47%) +0.13s (+13.06%) 1.09s 1.10s
Check Time 17.05s (± 0.50%) 17.04s (± 0.36%) -0.01s (- 0.05%) 16.94s 17.11s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.59s (± 0.40%) 20.74s (± 0.30%) 🟩-0.85s (- 3.94%) 20.64s 20.83s
xstate - node (v18.10.0, x64)
Memory used 548,657k (± 0.02%) 497,591k (± 0.01%) 🟩-51,067k (- 9.31%) 497,545k 497,660k
Parse Time 4.57s (± 0.45%) 2.97s (± 1.60%) 🟩-1.60s (-35.01%) 2.91s 3.03s
Bind Time 1.71s (± 1.03%) 1.51s (± 0.65%) 🟩-0.20s (-11.62%) 1.50s 1.52s
Check Time 2.73s (± 0.63%) 2.88s (± 0.61%) +0.15s (+ 5.44%) 2.86s 2.91s
Emit Time 0.09s (± 5.95%) 0.09s (± 0.00%) +0.00s (+ 3.85%) 0.09s 0.09s
Total Time 9.09s (± 0.43%) 7.44s (± 0.46%) 🟩-1.65s (-18.12%) 7.39s 7.48s
Angular - node (v16.17.1, x64)
Memory used 359,219k (± 0.00%) 348,349k (± 0.01%) 🟩-10,870k (- 3.03%) 348,285k 348,405k
Parse Time 4.18s (± 0.24%) 3.37s (± 0.69%) 🟩-0.81s (-19.31%) 3.34s 3.41s
Bind Time 1.23s (± 1.11%) 1.19s (± 0.43%) -0.03s (- 2.72%) 1.19s 1.20s
Check Time 9.40s (± 0.33%) 9.30s (± 0.29%) -0.10s (- 1.03%) 9.27s 9.34s
Emit Time 8.05s (± 0.76%) 8.27s (± 0.44%) +0.22s (+ 2.69%) 8.21s 8.31s
Total Time 22.85s (± 0.32%) 22.13s (± 0.13%) 🟩-0.73s (- 3.17%) 22.09s 22.17s
Compiler-Unions - node (v16.17.1, x64)
Memory used 195,380k (± 0.90%) 192,175k (± 0.02%) -3,205k (- 1.64%) 192,116k 192,211k
Parse Time 1.81s (± 0.65%) 1.63s (± 0.84%) 🟩-0.18s (-10.05%) 1.61s 1.64s
Bind Time 0.84s (± 0.48%) 0.80s (± 0.51%) 🟩-0.04s (- 5.15%) 0.79s 0.80s
Check Time 10.39s (± 0.72%) 10.31s (± 0.47%) -0.07s (- 0.71%) 10.25s 10.39s
Emit Time 3.05s (± 0.25%) 3.05s (± 1.07%) +0.01s (+ 0.22%) 3.02s 3.11s
Total Time 16.08s (± 0.52%) 15.79s (± 0.34%) -0.29s (- 1.81%) 15.69s 15.84s
Monaco - node (v16.17.1, x64)
Memory used 343,240k (± 0.01%) 341,860k (± 0.01%) -1,380k (- 0.40%) 341,846k 341,895k
Parse Time 3.17s (± 1.01%) 3.04s (± 1.12%) 🟩-0.13s (- 4.21%) 2.99s 3.08s
Bind Time 1.11s (± 0.89%) 1.08s (± 0.70%) -0.03s (- 2.41%) 1.07s 1.09s
Check Time 7.71s (± 0.32%) 7.71s (± 0.53%) -0.00s (- 0.02%) 7.66s 7.78s
Emit Time 4.54s (± 0.62%) 4.53s (± 0.40%) -0.00s (- 0.11%) 4.50s 4.55s
Total Time 16.53s (± 0.38%) 16.36s (± 0.47%) -0.17s (- 1.03%) 16.25s 16.47s
TFS - node (v16.17.1, x64)
Memory used 299,761k (± 0.01%) 299,850k (± 0.01%) +89k (+ 0.03%) 299,829k 299,876k
Parse Time 2.47s (± 1.08%) 2.48s (± 1.40%) +0.02s (+ 0.61%) 2.45s 2.55s
Bind Time 1.25s (± 0.41%) 1.01s (± 0.75%) 🟩-0.25s (-19.55%) 1.00s 1.02s
Check Time 7.20s (± 0.43%) 7.48s (± 0.37%) +0.27s (+ 3.79%) 7.44s 7.52s
Emit Time 4.22s (± 1.01%) 4.20s (± 0.49%) -0.02s (- 0.43%) 4.17s 4.23s
Total Time 15.14s (± 0.45%) 15.18s (± 0.34%) +0.03s (+ 0.21%) 15.12s 15.26s
material-ui - node (v16.17.1, x64)
Memory used 476,048k (± 0.02%) 462,153k (± 0.02%) -13,895k (- 2.92%) 462,075k 462,274k
Parse Time 3.71s (± 0.15%) 2.70s (± 0.45%) 🟩-1.01s (-27.23%) 2.69s 2.72s
Bind Time 1.02s (± 0.00%) 1.17s (± 0.54%) +0.15s (+14.71%) 1.16s 1.18s
Check Time 18.05s (± 0.39%) 18.11s (± 0.76%) +0.06s (+ 0.34%) 18.03s 18.38s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.78s (± 0.32%) 21.99s (± 0.62%) 🟩-0.79s (- 3.49%) 21.90s 22.26s
xstate - node (v16.17.1, x64)
Memory used 546,239k (± 0.02%) 495,504k (± 0.03%) 🟩-50,735k (- 9.29%) 495,295k 495,718k
Parse Time 4.74s (± 0.28%) 3.14s (± 0.24%) 🟩-1.60s (-33.81%) 3.13s 3.15s
Bind Time 1.78s (± 4.71%) 1.59s (± 0.51%) 🟩-0.19s (-10.94%) 1.58s 1.60s
Check Time 3.01s (± 2.95%) 3.15s (± 0.58%) +0.14s (+ 4.76%) 3.12s 3.17s
Emit Time 0.09s (± 5.53%) 0.09s (± 4.45%) -0.00s (- 1.79%) 0.09s 0.10s
Total Time 9.62s (± 0.42%) 7.98s (± 0.22%) 🟩-1.65s (-17.11%) 7.95s 8.00s
Angular - node (v14.15.1, x64)
Memory used 352,827k (± 0.01%) 342,213k (± 0.01%) 🟩-10,615k (- 3.01%) 342,174k 342,241k
Parse Time 4.23s (± 0.38%) 3.51s (± 0.84%) 🟩-0.72s (-17.11%) 3.47s 3.55s
Bind Time 1.28s (± 0.49%) 1.24s (± 0.51%) 🟩-0.04s (- 3.13%) 1.23s 1.25s
Check Time 9.66s (± 0.50%) 9.60s (± 0.41%) -0.06s (- 0.66%) 9.54s 9.66s
Emit Time 8.41s (± 0.69%) 8.60s (± 0.60%) +0.18s (+ 2.14%) 8.54s 8.68s
Total Time 23.59s (± 0.19%) 22.93s (± 0.40%) -0.65s (- 2.77%) 22.85s 23.11s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,194k (± 0.07%) 187,513k (± 0.02%) -1,681k (- 0.89%) 187,462k 187,572k
Parse Time 1.85s (± 0.44%) 1.66s (± 0.62%) 🟩-0.18s (- 9.93%) 1.65s 1.68s
Bind Time 0.86s (± 0.60%) 0.82s (± 1.48%) 🟩-0.04s (- 4.67%) 0.81s 0.84s
Check Time 10.39s (± 0.45%) 10.33s (± 0.40%) -0.06s (- 0.58%) 10.28s 10.40s
Emit Time 3.38s (± 5.21%) 3.16s (± 1.34%) 🟩-0.22s (- 6.36%) 3.10s 3.21s
Total Time 16.47s (± 1.26%) 15.98s (± 0.45%) 🟩-0.49s (- 3.00%) 15.91s 16.11s
Monaco - node (v14.15.1, x64)
Memory used 338,025k (± 0.00%) 336,730k (± 0.02%) -1,296k (- 0.38%) 336,684k 336,812k
Parse Time 3.22s (± 0.67%) 3.06s (± 1.16%) 🟩-0.16s (- 5.02%) 3.02s 3.10s
Bind Time 1.11s (± 0.68%) 1.10s (± 0.47%) -0.01s (- 1.05%) 1.09s 1.10s
Check Time 8.06s (± 0.26%) 8.01s (± 0.44%) -0.05s (- 0.62%) 7.96s 8.05s
Emit Time 4.77s (± 0.81%) 4.75s (± 0.45%) -0.02s (- 0.35%) 4.71s 4.77s
Total Time 17.16s (± 0.24%) 16.92s (± 0.44%) -0.24s (- 1.39%) 16.79s 17.01s
TFS - node (v14.15.1, x64)
Memory used 294,575k (± 0.00%) 294,781k (± 0.00%) +206k (+ 0.07%) 294,768k 294,799k
Parse Time 2.74s (± 0.58%) 2.71s (± 1.16%) -0.04s (- 1.28%) 2.65s 2.74s
Bind Time 1.11s (± 0.47%) 1.09s (± 1.35%) -0.02s (- 1.36%) 1.08s 1.12s
Check Time 7.51s (± 0.40%) 7.53s (± 0.41%) +0.02s (+ 0.27%) 7.49s 7.57s
Emit Time 4.62s (± 0.24%) 4.61s (± 0.53%) -0.01s (- 0.11%) 4.58s 4.65s
Total Time 15.98s (± 0.24%) 15.94s (± 0.50%) -0.04s (- 0.23%) 15.82s 16.05s
material-ui - node (v14.15.1, x64)
Memory used 471,559k (± 0.00%) 457,993k (± 0.00%) -13,566k (- 2.88%) 457,963k 458,009k
Parse Time 3.93s (± 0.57%) 3.09s (± 0.48%) 🟩-0.84s (-21.30%) 3.08s 3.11s
Bind Time 1.05s (± 0.85%) 0.98s (± 1.29%) 🟩-0.07s (- 6.67%) 0.96s 1.00s
Check Time 19.05s (± 0.35%) 18.48s (± 0.30%) 🟩-0.58s (- 3.04%) 18.40s 18.57s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 24.03s (± 0.32%) 22.55s (± 0.29%) 🟩-1.49s (- 6.19%) 22.46s 22.65s
xstate - node (v14.15.1, x64)
Memory used 534,446k (± 0.01%) 484,048k (± 0.01%) 🟩-50,398k (- 9.43%) 484,024k 484,094k
Parse Time 5.12s (± 0.29%) 3.36s (± 1.03%) 🟩-1.77s (-34.46%) 3.31s 3.40s
Bind Time 1.70s (± 0.53%) 1.78s (± 0.66%) +0.08s (+ 4.61%) 1.77s 1.80s
Check Time 3.10s (± 0.67%) 3.08s (± 0.76%) -0.02s (- 0.59%) 3.05s 3.11s
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) 0.00s ( 0.00%) 0.10s 0.10s
Total Time 10.02s (± 0.28%) 8.32s (± 0.65%) 🟩-1.70s (-16.97%) 8.25s 8.38s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52466 6
Baseline main 6

TSServer

Comparison Report - main..52466
Metric main 52466 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,525ms (± 1.72%) 2,260ms (± 0.51%) 🟩-265ms (-10.50%) 2,243ms 2,273ms
Req 2 - geterr 5,505ms (± 0.65%) 5,466ms (± 1.04%) -39ms (- 0.70%) 5,401ms 5,558ms
Req 3 - references 365ms (± 0.84%) 357ms (± 2.15%) -8ms (- 2.28%) 349ms 370ms
Req 4 - navto 284ms (± 1.03%) 279ms (± 0.27%) -6ms (- 1.93%) 278ms 280ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 66ms (± 0.96%) 62ms (± 0.84%) 🟩-4ms (- 6.57%) 61ms 62ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,727ms (± 1.11%) 2,499ms (± 2.10%) 🟩-228ms (- 8.35%) 2,425ms 2,548ms
Req 2 - geterr 4,060ms (± 0.40%) 4,061ms (± 0.24%) +1ms (+ 0.03%) 4,047ms 4,072ms
Req 3 - references 368ms (± 0.76%) 367ms (± 0.53%) -0ms (- 0.05%) 364ms 370ms
Req 4 - navto 299ms (± 0.77%) 293ms (± 0.41%) -7ms (- 2.17%) 291ms 294ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 81ms (± 2.12%) 73ms (± 1.22%) 🟩-8ms (-10.06%) 72ms 74ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,507ms (± 0.64%) 2,635ms (± 0.58%) 🟩-872ms (-24.86%) 2,618ms 2,653ms
Req 2 - geterr 1,429ms (± 1.45%) 1,424ms (± 0.81%) -5ms (- 0.35%) 1,410ms 1,441ms
Req 3 - references 105ms (± 1.89%) 110ms (± 0.00%) +6ms (+ 5.26%) 110ms 110ms
Req 4 - navto 358ms (± 1.63%) 359ms (± 0.99%) +1ms (+ 0.33%) 355ms 365ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 468ms (± 1.49%) 455ms (± 1.99%) -13ms (- 2.67%) 444ms 467ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,777ms (± 0.31%) 2,555ms (± 0.98%) 🟩-223ms (- 8.01%) 2,509ms 2,583ms
Req 2 - geterr 5,878ms (± 0.50%) 5,864ms (± 0.34%) -14ms (- 0.24%) 5,835ms 5,886ms
Req 3 - references 377ms (± 1.36%) 362ms (± 1.13%) 🟩-14ms (- 3.81%) 358ms 370ms
Req 4 - navto 278ms (± 0.79%) 274ms (± 0.84%) -4ms (- 1.38%) 271ms 278ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 76ms (± 8.87%) 70ms (± 3.93%) 🟩-6ms (- 8.10%) 66ms 73ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,941ms (± 0.70%) 2,670ms (± 1.09%) 🟩-272ms (- 9.24%) 2,629ms 2,699ms
Req 2 - geterr 4,408ms (± 0.44%) 4,371ms (± 0.17%) -37ms (- 0.84%) 4,358ms 4,380ms
Req 3 - references 379ms (± 0.73%) 375ms (± 0.75%) -4ms (- 0.92%) 372ms 380ms
Req 4 - navto 287ms (± 0.62%) 290ms (± 0.38%) +3ms (+ 1.05%) 289ms 292ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 72ms (± 0.72%) 79ms (± 1.03%) +8ms (+10.70%) 78ms 80ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,628ms (± 0.17%) 2,755ms (± 0.24%) 🟩-872ms (-24.05%) 2,744ms 2,761ms
Req 2 - geterr 1,559ms (± 0.61%) 1,562ms (± 1.24%) +3ms (+ 0.18%) 1,536ms 1,593ms
Req 3 - references 112ms (± 1.85%) 116ms (± 0.89%) +5ms (+ 4.18%) 115ms 118ms
Req 4 - navto 342ms (± 1.06%) 347ms (± 1.07%) +5ms (+ 1.46%) 343ms 351ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 481ms (± 0.73%) 468ms (± 0.80%) -13ms (- 2.67%) 463ms 472ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,902ms (± 0.26%) 2,670ms (± 0.31%) 🟩-233ms (- 8.01%) 2,657ms 2,680ms
Req 2 - geterr 6,258ms (± 0.53%) 6,212ms (± 0.92%) -46ms (- 0.73%) 6,138ms 6,307ms
Req 3 - references 390ms (± 0.78%) 371ms (± 1.26%) 🟩-20ms (- 5.04%) 366ms 379ms
Req 4 - navto 283ms (± 1.43%) 280ms (± 2.20%) -3ms (- 1.00%) 275ms 289ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 85ms (± 9.12%) 88ms (±11.31%) +3ms (+ 3.13%) 72ms 95ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,078ms (± 0.61%) 2,824ms (± 0.32%) 🟩-254ms (- 8.24%) 2,810ms 2,831ms
Req 2 - geterr 4,698ms (± 0.42%) 4,651ms (± 0.45%) -47ms (- 1.00%) 4,632ms 4,690ms
Req 3 - references 404ms (± 0.53%) 388ms (± 0.55%) 🟩-16ms (- 3.96%) 385ms 391ms
Req 4 - navto 292ms (± 1.00%) 294ms (± 1.55%) +2ms (+ 0.57%) 288ms 299ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 83ms (± 4.32%) 74ms (± 1.14%) 🟩-9ms (-10.91%) 73ms 75ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,989ms (± 0.61%) 2,862ms (± 0.24%) 🟩-1,127ms (-28.26%) 2,851ms 2,872ms
Req 2 - geterr 1,524ms (± 1.32%) 1,546ms (± 0.67%) +22ms (+ 1.42%) 1,531ms 1,559ms
Req 3 - references 132ms (± 1.51%) 130ms (± 2.11%) -2ms (- 1.77%) 125ms 133ms
Req 4 - navto 373ms (± 0.81%) 371ms (± 0.81%) -1ms (- 0.36%) 368ms 375ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 511ms (± 2.03%) 492ms (± 2.95%) 🟩-19ms (- 3.78%) 472ms 502ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52466 6
Baseline main 6

Startup

Comparison Report - main..52466
Metric main 52466 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 141.85ms (± 0.14%) 142.43ms (± 0.18%) +0.58ms (+ 0.41%) 141.73ms 147.28ms
tsserver-startup - node (v16.17.1, x64)
Execution time 225.50ms (± 0.17%) 226.93ms (± 0.19%) +1.43ms (+ 0.63%) 226.05ms 234.38ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 227.93ms (± 0.15%) 229.12ms (± 0.21%) +1.20ms (+ 0.52%) 228.17ms 239.93ms
typescript-startup - node (v16.17.1, x64)
Execution time 208.91ms (± 0.16%) 209.99ms (± 0.17%) +1.07ms (+ 0.51%) 209.11ms 216.91ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52466 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member

Holy moly, we spend that much time on JSDoc?

@sandersn
Copy link
Member Author

Yes

@sandersn
Copy link
Member Author

Yep. Yes indeed.

@sandersn
Don't skip in tsserver or if comment contains @link/@see
88e0434
@sandersn
oops, really check @see
3d5d2a6 
also delete comment in checker, that's for a different experiment
@sandersn sandersn changed the title Skip JSDoc in .ts files Skip parsing JSDoc in .ts files Jan 27, 2023
@sandersn
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023 •
edited

Heya @sandersn, I've started to run the perf test suite on this PR at 3d5d2a6. You can monitor the build here.

Update: The results are in!

@weswigham
Copy link
Member

This looks great, hah. Do the parser time savings in our benches correspond, percentage-wise, with how much text is jsdoc, or does jsdoc have an outsized parse time impact? I ask because, if the later, it may still be worth also looking at if we can make jsdoc parsing faster for the sake of LS operations that actually need the jsdoc.

@sandersn
Copy link
Member Author

sandersn commented Jan 27, 2023 •
edited

Do the parser time savings in our benches correspond, percentage-wise?

Uhhh, not really? Correlation is 27%, which is not high, although xstate is kind of an outlier and if you drop it the correlation is 66%. It's definitely worth investigating jsdoc parsing.

Edit: There are only 50,000 characters of comments in xstate so I looked at all of them. There's nothing interesting there, unless we are pathologically bad at parsing the one or two markdown links. I think it's the perf tests being wonky, so let's see what the second run results are like.

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52466
Metric main 52466 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 359,841k (± 0.02%) 359,810k (± 0.02%) -32k (- 0.01%) 359,722k 359,896k
Parse Time 3.96s (± 0.76%) 3.96s (± 0.49%) -0.01s (- 0.17%) 3.94s 3.99s
Bind Time 1.17s (± 0.47%) 1.17s (± 0.00%) -0.00s (- 0.43%) 1.17s 1.17s
Check Time 8.64s (± 0.57%) 8.61s (± 0.31%) -0.03s (- 0.31%) 8.58s 8.64s
Emit Time 7.62s (± 0.59%) 7.58s (± 0.54%) -0.04s (- 0.48%) 7.54s 7.65s
Total Time 21.40s (± 0.34%) 21.32s (± 0.35%) -0.07s (- 0.34%) 21.24s 21.44s
Compiler-Unions - node (v18.10.0, x64)
Memory used 194,520k (± 1.51%) 195,361k (± 1.57%) +841k (+ 0.43%) 192,325k 198,218k
Parse Time 1.64s (± 1.41%) 1.63s (± 1.62%) -0.01s (- 0.81%) 1.59s 1.65s
Bind Time 0.80s (± 0.69%) 0.79s (± 0.00%) -0.01s (- 0.63%) 0.79s 0.79s
Check Time 9.67s (± 0.96%) 9.64s (± 1.04%) -0.03s (- 0.29%) 9.54s 9.81s
Emit Time 2.81s (± 2.25%) 2.86s (± 4.14%) +0.05s (+ 1.66%) 2.79s 3.10s
Total Time 14.92s (± 0.62%) 14.91s (± 0.99%) -0.00s (- 0.01%) 14.78s 15.12s
Monaco - node (v18.10.0, x64)
Memory used 343,959k (± 0.01%) 344,009k (± 0.02%) +50k (+ 0.01%) 343,925k 344,076k
Parse Time 2.96s (± 0.85%) 2.95s (± 0.61%) -0.01s (- 0.34%) 2.92s 2.97s
Bind Time 1.04s (± 1.12%) 1.04s (± 1.12%) -0.00s (- 0.32%) 1.02s 1.05s
Check Time 7.05s (± 0.56%) 7.02s (± 0.64%) -0.03s (- 0.40%) 6.97s 7.09s
Emit Time 4.32s (± 0.79%) 4.34s (± 1.32%) +0.02s (+ 0.42%) 4.29s 4.45s
Total Time 15.37s (± 0.23%) 15.35s (± 0.55%) -0.02s (- 0.13%) 15.26s 15.50s
TFS - node (v18.10.0, x64)
Memory used 300,378k (± 0.00%) 300,373k (± 0.01%) -5k (- 0.00%) 300,345k 300,401k
Parse Time 2.27s (± 1.14%) 2.23s (± 0.67%) -0.04s (- 1.83%) 2.22s 2.26s
Bind Time 1.17s (± 0.00%) 1.17s (± 1.00%) +0.00s (+ 0.14%) 1.16s 1.19s
Check Time 6.55s (± 0.80%) 6.50s (± 0.40%) -0.06s (- 0.89%) 6.46s 6.53s
Emit Time 3.93s (± 0.82%) 3.91s (± 0.60%) -0.02s (- 0.38%) 3.88s 3.94s
Total Time 13.93s (± 0.72%) 13.81s (± 0.33%) -0.12s (- 0.84%) 13.75s 13.88s
material-ui - node (v18.10.0, x64)
Memory used 476,715k (± 0.00%) 476,726k (± 0.01%) +12k (+ 0.00%) 476,677k 476,818k
Parse Time 3.56s (± 0.63%) 3.55s (± 1.66%) -0.02s (- 0.47%) 3.44s 3.60s
Bind Time 0.97s (± 0.65%) 0.99s (± 4.18%) +0.02s (+ 1.72%) 0.96s 1.07s
Check Time 17.15s (± 0.80%) 17.07s (± 0.78%) -0.08s (- 0.47%) 16.91s 17.21s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.68s (± 0.63%) 21.61s (± 0.72%) -0.08s (- 0.37%) 21.39s 21.77s
xstate - node (v18.10.0, x64)
Memory used 548,604k (± 0.01%) 548,615k (± 0.02%) +11k (+ 0.00%) 548,540k 548,752k
Parse Time 4.56s (± 0.66%) 4.55s (± 0.45%) -0.02s (- 0.37%) 4.52s 4.57s
Bind Time 1.71s (± 0.68%) 1.70s (± 1.25%) -0.01s (- 0.58%) 1.67s 1.73s
Check Time 2.73s (± 1.10%) 2.74s (± 0.55%) +0.01s (+ 0.37%) 2.72s 2.75s
Emit Time 0.08s (± 0.00%) 0.08s (± 6.19%) +0.00s (+ 4.17%) 0.08s 0.09s
Total Time 9.09s (± 0.38%) 9.08s (± 0.56%) -0.02s (- 0.18%) 9.02s 9.14s
Angular - node (v16.17.1, x64)
Memory used 359,216k (± 0.01%) 359,215k (± 0.00%) -1k (- 0.00%) 359,191k 359,237k
Parse Time 4.19s (± 0.41%) 4.18s (± 0.23%) -0.01s (- 0.16%) 4.17s 4.19s
Bind Time 1.22s (± 0.84%) 1.23s (± 0.66%) +0.00s (+ 0.27%) 1.21s 1.23s
Check Time 9.39s (± 0.41%) 9.40s (± 0.38%) +0.01s (+ 0.05%) 9.35s 9.45s
Emit Time 8.07s (± 0.71%) 8.06s (± 0.47%) -0.01s (- 0.14%) 8.00s 8.10s
Total Time 22.87s (± 0.40%) 22.86s (± 0.29%) -0.01s (- 0.04%) 22.80s 22.97s
Compiler-Unions - node (v16.17.1, x64)
Memory used 194,849k (± 0.76%) 194,204k (± 0.03%) -645k (- 0.33%) 194,170k 194,335k
Parse Time 1.80s (± 0.57%) 1.80s (± 0.45%) +0.00s (+ 0.00%) 1.79s 1.81s
Bind Time 0.84s (± 1.17%) 0.85s (± 0.48%) +0.01s (+ 1.59%) 0.85s 0.86s
Check Time 10.36s (± 0.49%) 10.34s (± 0.31%) -0.03s (- 0.26%) 10.29s 10.37s
Emit Time 3.05s (± 0.87%) 3.05s (± 0.40%) +0.01s (+ 0.27%) 3.04s 3.07s
Total Time 16.05s (± 0.36%) 16.04s (± 0.17%) -0.01s (- 0.04%) 16.01s 16.08s
Monaco - node (v16.17.1, x64)
Memory used 343,253k (± 0.01%) 343,304k (± 0.01%) +52k (+ 0.02%) 343,241k 343,353k
Parse Time 3.18s (± 1.01%) 3.18s (± 1.37%) +0.00s (+ 0.05%) 3.12s 3.25s
Bind Time 1.11s (± 0.95%) 1.12s (± 0.46%) +0.01s (+ 1.06%) 1.11s 1.12s
Check Time 7.74s (± 0.48%) 7.71s (± 0.30%) -0.03s (- 0.45%) 7.67s 7.74s
Emit Time 4.52s (± 0.74%) 4.55s (± 0.49%) +0.03s (+ 0.63%) 4.51s 4.57s
Total Time 16.55s (± 0.38%) 16.56s (± 0.39%) +0.01s (+ 0.04%) 16.47s 16.65s
TFS - node (v16.17.1, x64)
Memory used 299,756k (± 0.00%) 299,756k (± 0.00%) -0k (- 0.00%) 299,736k 299,770k
Parse Time 2.47s (± 1.53%) 2.48s (± 1.00%) +0.01s (+ 0.34%) 2.44s 2.51s
Bind Time 1.25s (± 0.60%) 1.25s (± 0.00%) -0.00s (- 0.13%) 1.25s 1.25s
Check Time 7.18s (± 0.44%) 7.19s (± 0.39%) +0.01s (+ 0.07%) 7.16s 7.24s
Emit Time 4.24s (± 0.86%) 4.20s (± 0.37%) -0.04s (- 0.98%) 4.18s 4.22s
Total Time 15.15s (± 0.33%) 15.13s (± 0.38%) -0.03s (- 0.19%) 15.08s 15.22s
material-ui - node (v16.17.1, x64)
Memory used 476,064k (± 0.02%) 476,074k (± 0.01%) +10k (+ 0.00%) 476,007k 476,147k
Parse Time 3.71s (± 0.22%) 3.73s (± 0.22%) +0.01s (+ 0.27%) 3.72s 3.74s
Bind Time 1.02s (± 0.80%) 1.02s (± 0.62%) -0.00s (- 0.33%) 1.01s 1.03s
Check Time 18.16s (± 0.46%) 18.15s (± 0.57%) -0.01s (- 0.06%) 18.02s 18.31s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.90s (± 0.38%) 22.90s (± 0.47%) -0.00s (- 0.01%) 22.76s 23.07s
xstate - node (v16.17.1, x64)
Memory used 546,223k (± 0.02%) 546,239k (± 0.01%) +16k (+ 0.00%) 546,198k 546,380k
Parse Time 4.77s (± 0.28%) 4.76s (± 0.57%) -0.01s (- 0.14%) 4.73s 4.81s
Bind Time 1.83s (± 0.75%) 1.84s (± 0.44%) +0.00s (+ 0.09%) 1.83s 1.85s
Check Time 2.97s (± 0.46%) 2.97s (± 0.55%) -0.00s (- 0.06%) 2.94s 2.98s
Emit Time 0.10s (± 5.76%) 0.10s (± 5.76%) 0.00s ( 0.00%) 0.09s 0.10s
Total Time 9.67s (± 0.17%) 9.66s (± 0.41%) -0.01s (- 0.09%) 9.61s 9.72s
Angular - node (v14.15.1, x64)
Memory used 352,853k (± 0.00%) 352,826k (± 0.01%) -27k (- 0.01%) 352,790k 352,910k
Parse Time 4.24s (± 0.58%) 4.23s (± 0.36%) -0.01s (- 0.31%) 4.21s 4.25s
Bind Time 1.29s (± 0.63%) 1.28s (± 0.85%) -0.01s (- 0.52%) 1.26s 1.29s
Check Time 9.72s (± 0.38%) 9.69s (± 0.36%) -0.03s (- 0.31%) 9.64s 9.74s
Emit Time 8.40s (± 0.73%) 8.35s (± 0.46%) -0.05s (- 0.60%) 8.30s 8.41s
Total Time 23.64s (± 0.38%) 23.55s (± 0.25%) -0.10s (- 0.41%) 23.46s 23.61s
Compiler-Unions - node (v14.15.1, x64)
Memory used 190,178k (± 0.87%) 189,091k (± 0.01%) -1,087k (- 0.57%) 189,074k 189,108k
Parse Time 1.84s (± 0.49%) 1.85s (± 0.41%) +0.01s (+ 0.63%) 1.84s 1.86s
Bind Time 0.86s (± 0.73%) 0.86s (± 0.48%) -0.00s (- 0.19%) 0.85s 0.86s
Check Time 10.37s (± 0.59%) 10.34s (± 0.69%) -0.03s (- 0.27%) 10.26s 10.46s
Emit Time 3.46s (± 1.15%) 3.47s (± 1.88%) +0.01s (+ 0.24%) 3.39s 3.55s
Total Time 16.54s (± 0.63%) 16.53s (± 0.73%) -0.01s (- 0.05%) 16.41s 16.73s
Monaco - node (v14.15.1, x64)
Memory used 338,019k (± 0.01%) 338,026k (± 0.00%) +8k (+ 0.00%) 338,012k 338,049k
Parse Time 3.22s (± 1.09%) 3.24s (± 0.73%) +0.02s (+ 0.62%) 3.21s 3.26s
Bind Time 1.11s (± 0.68%) 1.11s (± 0.37%) +0.00s (+ 0.30%) 1.11s 1.12s
Check Time 8.05s (± 0.26%) 8.03s (± 0.35%) -0.03s (- 0.33%) 8.00s 8.08s
Emit Time 4.76s (± 0.39%) 4.74s (± 0.34%) -0.02s (- 0.35%) 4.73s 4.77s
Total Time 17.14s (± 0.26%) 17.12s (± 0.31%) -0.02s (- 0.15%) 17.05s 17.17s
TFS - node (v14.15.1, x64)
Memory used 294,588k (± 0.01%) 294,606k (± 0.01%) +18k (+ 0.01%) 294,583k 294,628k
Parse Time 2.74s (± 0.72%) 2.75s (± 0.51%) +0.01s (+ 0.18%) 2.73s 2.77s
Bind Time 1.11s (± 0.37%) 1.10s (± 1.41%) -0.01s (- 1.05%) 1.08s 1.12s
Check Time 7.50s (± 0.66%) 7.50s (± 0.40%) -0.00s (- 0.04%) 7.45s 7.53s
Emit Time 4.60s (± 0.58%) 4.59s (± 0.67%) -0.01s (- 0.14%) 4.56s 4.64s
Total Time 15.96s (± 0.36%) 15.94s (± 0.32%) -0.02s (- 0.15%) 15.89s 16.03s
material-ui - node (v14.15.1, x64)
Memory used 471,562k (± 0.00%) 471,559k (± 0.00%) -3k (- 0.00%) 471,539k 471,569k
Parse Time 3.93s (± 0.71%) 3.92s (± 0.45%) -0.01s (- 0.21%) 3.90s 3.95s
Bind Time 1.04s (± 1.16%) 1.04s (± 0.49%) -0.00s (- 0.00%) 1.04s 1.05s
Check Time 19.09s (± 0.74%) 19.00s (± 0.30%) -0.09s (- 0.46%) 18.91s 19.07s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 24.07s (± 0.67%) 23.97s (± 0.30%) -0.10s (- 0.41%) 23.86s 24.05s
xstate - node (v14.15.1, x64)
Memory used 534,443k (± 0.01%) 534,504k (± 0.01%) +61k (+ 0.01%) 534,406k 534,565k
Parse Time 5.17s (± 0.76%) 5.19s (± 0.33%) +0.02s (+ 0.42%) 5.16s 5.21s
Bind Time 1.72s (± 1.13%) 1.74s (± 0.47%) +0.02s (+ 1.07%) 1.73s 1.75s
Check Time 3.10s (± 0.67%) 3.09s (± 0.49%) -0.00s (- 0.11%) 3.07s 3.11s
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) 0.00s ( 0.00%) 0.10s 0.10s
Total Time 10.08s (± 0.41%) 10.12s (± 0.18%) +0.04s (+ 0.38%) 10.08s 10.13s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52466 6
Baseline main 6

TSServer

Comparison Report - main..52466
Metric main 52466 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,519ms (± 1.71%) 2,496ms (± 0.99%) -23ms (- 0.91%) 2,469ms 2,533ms
Req 2 - geterr 5,499ms (± 0.31%) 5,505ms (± 0.47%) +6ms (+ 0.11%) 5,476ms 5,541ms
Req 3 - references 365ms (± 0.89%) 366ms (± 0.46%) +1ms (+ 0.37%) 364ms 369ms
Req 4 - navto 285ms (± 0.31%) 283ms (± 0.85%) -2ms (- 0.58%) 279ms 286ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 67ms (± 3.53%) 66ms (± 3.45%) -1ms (- 1.49%) 64ms 70ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,739ms (± 1.36%) 2,769ms (± 1.22%) +30ms (+ 1.08%) 2,727ms 2,823ms
Req 2 - geterr 4,050ms (± 0.67%) 4,059ms (± 0.46%) +9ms (+ 0.23%) 4,025ms 4,082ms
Req 3 - references 367ms (± 0.64%) 369ms (± 0.61%) +2ms (+ 0.50%) 367ms 373ms
Req 4 - navto 299ms (± 1.09%) 299ms (± 0.54%) -0ms (- 0.11%) 296ms 300ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 82ms (± 1.09%) 82ms (± 0.63%) +0ms (+ 0.41%) 82ms 83ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,487ms (± 0.42%) 3,487ms (± 0.81%) +0ms (+ 0.01%) 3,451ms 3,515ms
Req 2 - geterr 1,418ms (± 1.53%) 1,417ms (± 0.93%) -1ms (- 0.04%) 1,405ms 1,436ms
Req 3 - references 105ms (± 1.44%) 104ms (± 1.12%) -1ms (- 0.48%) 103ms 106ms
Req 4 - navto 357ms (± 0.42%) 356ms (± 0.73%) -1ms (- 0.19%) 353ms 360ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 466ms (± 1.25%) 470ms (± 1.44%) +4ms (+ 0.93%) 462ms 478ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,764ms (± 0.85%) 2,770ms (± 0.70%) +6ms (+ 0.21%) 2,746ms 2,801ms
Req 2 - geterr 5,885ms (± 0.21%) 5,875ms (± 0.53%) -9ms (- 0.16%) 5,826ms 5,914ms
Req 3 - references 377ms (± 1.29%) 377ms (± 1.57%) +0ms (+ 0.09%) 373ms 389ms
Req 4 - navto 278ms (± 0.97%) 281ms (± 1.56%) +2ms (+ 0.84%) 275ms 286ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 73ms (± 3.92%) 80ms (±10.38%) +6ms (+ 8.41%) 69ms 88ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,936ms (± 0.47%) 2,923ms (± 0.30%) -14ms (- 0.46%) 2,906ms 2,930ms
Req 2 - geterr 4,396ms (± 0.40%) 4,397ms (± 0.45%) +1ms (+ 0.02%) 4,364ms 4,417ms
Req 3 - references 379ms (± 1.15%) 379ms (± 0.78%) -1ms (- 0.13%) 375ms 383ms
Req 4 - navto 288ms (± 0.36%) 287ms (± 0.71%) -1ms (- 0.23%) 284ms 290ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 72ms (± 1.05%) 72ms (± 1.36%) +0ms (+ 0.46%) 71ms 74ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,629ms (± 0.54%) 3,627ms (± 0.33%) -2ms (- 0.05%) 3,610ms 3,643ms
Req 2 - geterr 1,564ms (± 1.09%) 1,561ms (± 0.91%) -3ms (- 0.21%) 1,550ms 1,588ms
Req 3 - references 110ms (± 0.96%) 110ms (± 1.57%) +0ms (+ 0.30%) 107ms 112ms
Req 4 - navto 342ms (± 1.03%) 343ms (± 1.22%) +2ms (+ 0.54%) 340ms 350ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 478ms (± 0.68%) 483ms (± 0.97%) +5ms (+ 1.12%) 476ms 489ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,901ms (± 0.37%) 2,908ms (± 0.26%) +6ms (+ 0.22%) 2,896ms 2,919ms
Req 2 - geterr 6,284ms (± 0.32%) 6,289ms (± 0.50%) +5ms (+ 0.08%) 6,255ms 6,347ms
Req 3 - references 391ms (± 0.55%) 391ms (± 0.21%) 0ms ( 0.00%) 390ms 392ms
Req 4 - navto 284ms (± 1.61%) 281ms (± 0.61%) -3ms (- 0.94%) 279ms 283ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 87ms (± 5.94%) 86ms (± 5.95%) -2ms (- 1.72%) 78ms 92ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,094ms (± 1.33%) 3,086ms (± 0.74%) -8ms (- 0.25%) 3,058ms 3,119ms
Req 2 - geterr 4,703ms (± 0.47%) 4,694ms (± 0.54%) -9ms (- 0.18%) 4,651ms 4,720ms
Req 3 - references 404ms (± 1.28%) 404ms (± 0.73%) -1ms (- 0.12%) 400ms 408ms
Req 4 - navto 292ms (± 0.79%) 294ms (± 1.14%) +2ms (+ 0.63%) 291ms 299ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 80ms (± 0.94%) 81ms (± 4.09%) +1ms (+ 1.46%) 79ms 88ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,956ms (± 0.48%) 3,981ms (± 0.53%) +25ms (+ 0.64%) 3,956ms 4,013ms
Req 2 - geterr 1,543ms (± 1.69%) 1,533ms (± 1.29%) -10ms (- 0.66%) 1,512ms 1,561ms
Req 3 - references 133ms (± 0.88%) 129ms (± 4.18%) 🟩-4ms (- 3.13%) 121ms 136ms
Req 4 - navto 372ms (± 0.50%) 377ms (± 0.90%) +5ms (+ 1.35%) 374ms 383ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 508ms (± 1.43%) 495ms (± 1.33%) -13ms (- 2.49%) 487ms 504ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52466 6
Baseline main 6

Startup

Comparison Report - main..52466
Metric main 52466 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 141.87ms (± 0.22%) 142.03ms (± 0.23%) +0.16ms (+ 0.11%) 141.40ms 148.14ms
tsserver-startup - node (v16.17.1, x64)
Execution time 225.42ms (± 0.15%) 225.52ms (± 0.14%) +0.10ms (+ 0.04%) 224.65ms 228.69ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 227.96ms (± 0.17%) 228.02ms (± 0.13%) +0.06ms (+ 0.03%) 227.16ms 232.09ms
typescript-startup - node (v16.17.1, x64)
Execution time 208.91ms (± 0.18%) 209.03ms (± 0.17%) +0.12ms (+ 0.06%) 208.25ms 213.41ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52466 6
Baseline main 6

Developer Information:

Download Benchmark

@sandersn
Copy link
Member Author

@weswigham maybe you're right about the isTsserver check. The speedup is gone in the commit with the suspicious version of the check.

@sandersn
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 28, 2023 •
edited

Heya @sandersn, I've started to run the perf test suite on this PR at ebcbd11. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52466
Metric main 52466 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 359,841k (± 0.02%) 359,828k (± 0.02%) -14k (- 0.00%) 359,770k 359,920k
Parse Time 3.96s (± 0.76%) 3.97s (± 0.57%) +0.00s (+ 0.13%) 3.94s 3.99s
Bind Time 1.17s (± 0.47%) 1.17s (± 0.35%) -0.00s (- 0.28%) 1.17s 1.18s
Check Time 8.64s (± 0.57%) 8.63s (± 0.27%) -0.01s (- 0.08%) 8.59s 8.65s
Emit Time 7.62s (± 0.59%) 7.59s (± 0.48%) -0.03s (- 0.35%) 7.53s 7.63s
Total Time 21.40s (± 0.34%) 21.37s (± 0.19%) -0.03s (- 0.15%) 21.32s 21.44s
Compiler-Unions - node (v18.10.0, x64)
Memory used 194,520k (± 1.51%) 193,518k (± 1.22%) -1,002k (- 0.52%) 192,459k 198,334k
Parse Time 1.64s (± 1.41%) 1.63s (± 1.79%) -0.01s (- 0.61%) 1.59s 1.66s
Bind Time 0.80s (± 0.69%) 0.79s (± 0.52%) -0.00s (- 0.42%) 0.79s 0.80s
Check Time 9.67s (± 0.96%) 9.62s (± 1.07%) -0.04s (- 0.43%) 9.50s 9.77s
Emit Time 2.81s (± 2.25%) 2.80s (± 1.05%) -0.01s (- 0.36%) 2.75s 2.83s
Total Time 14.92s (± 0.62%) 14.85s (± 0.69%) -0.06s (- 0.44%) 14.76s 15.04s
Monaco - node (v18.10.0, x64)
Memory used 343,959k (± 0.01%) 344,011k (± 0.01%) +52k (+ 0.01%) 343,927k 344,065k
Parse Time 2.96s (± 0.85%) 2.96s (± 0.70%) +0.00s (+ 0.17%) 2.95s 3.00s
Bind Time 1.04s (± 1.12%) 1.04s (± 1.12%) -0.00s (- 0.32%) 1.02s 1.05s
Check Time 7.05s (± 0.56%) 7.05s (± 0.54%) +0.00s (+ 0.05%) 7.00s 7.11s
Emit Time 4.32s (± 0.79%) 4.34s (± 0.53%) +0.02s (+ 0.42%) 4.31s 4.36s
Total Time 15.37s (± 0.23%) 15.39s (± 0.31%) +0.02s (+ 0.15%) 15.35s 15.47s
TFS - node (v18.10.0, x64)
Memory used 300,378k (± 0.00%) 300,344k (± 0.01%) -34k (- 0.01%) 300,303k 300,376k
Parse Time 2.27s (± 1.14%) 2.25s (± 1.71%) -0.03s (- 1.32%) 2.20s 2.31s
Bind Time 1.17s (± 0.00%) 1.17s (± 0.00%) 0.00s ( 0.00%) 1.17s 1.17s
Check Time 6.55s (± 0.80%) 6.50s (± 0.40%) -0.06s (- 0.89%) 6.45s 6.52s
Emit Time 3.93s (± 0.82%) 3.92s (± 0.78%) -0.01s (- 0.17%) 3.88s 3.96s
Total Time 13.93s (± 0.72%) 13.83s (± 0.21%) -0.10s (- 0.74%) 13.78s 13.86s
material-ui - node (v18.10.0, x64)
Memory used 476,715k (± 0.00%) 476,751k (± 0.02%) +36k (+ 0.01%) 476,673k 476,884k
Parse Time 3.56s (± 0.63%) 3.51s (± 2.06%) -0.05s (- 1.40%) 3.42s 3.57s
Bind Time 0.97s (± 0.65%) 1.01s (± 6.55%) +0.04s (+ 3.95%) 0.96s 1.12s
Check Time 17.15s (± 0.80%) 17.10s (± 0.70%) -0.05s (- 0.32%) 16.95s 17.26s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.68s (± 0.63%) 21.62s (± 0.55%) -0.06s (- 0.30%) 21.47s 21.80s
xstate - node (v18.10.0, x64)
Memory used 548,604k (± 0.01%) 548,539k (± 0.01%) -66k (- 0.01%) 548,468k 548,661k
Parse Time 4.56s (± 0.66%) 4.57s (± 0.36%) +0.00s (+ 0.07%) 4.55s 4.59s
Bind Time 1.71s (± 0.68%) 1.71s (± 1.30%) -0.00s (- 0.19%) 1.68s 1.74s
Check Time 2.73s (± 1.10%) 2.74s (± 0.63%) +0.02s (+ 0.55%) 2.72s 2.77s
Emit Time 0.08s (± 0.00%) 0.09s (± 6.44%) +0.01s (+ 6.25%) 0.08s 0.09s
Total Time 9.09s (± 0.38%) 9.12s (± 0.43%) +0.02s (+ 0.22%) 9.07s 9.17s
Angular - node (v16.17.1, x64)
Memory used 359,216k (± 0.01%) 359,224k (± 0.01%) +8k (+ 0.00%) 359,200k 359,265k
Parse Time 4.19s (± 0.41%) 4.19s (± 0.18%) 0.00s ( 0.00%) 4.18s 4.20s
Bind Time 1.22s (± 0.84%) 1.22s (± 0.81%) -0.01s (- 0.41%) 1.21s 1.23s
Check Time 9.39s (± 0.41%) 9.40s (± 0.20%) +0.02s (+ 0.16%) 9.38s 9.43s
Emit Time 8.07s (± 0.71%) 8.07s (± 0.42%) 0.00s ( 0.00%) 8.03s 8.11s
Total Time 22.87s (± 0.40%) 22.89s (± 0.26%) +0.01s (+ 0.06%) 22.82s 22.97s
Compiler-Unions - node (v16.17.1, x64)
Memory used 194,849k (± 0.76%) 194,219k (± 0.05%) -630k (- 0.32%) 194,108k 194,354k
Parse Time 1.80s (± 0.57%) 1.79s (± 0.91%) -0.01s (- 0.56%) 1.76s 1.81s
Bind Time 0.84s (± 1.17%) 0.84s (± 0.65%) +0.01s (+ 0.80%) 0.84s 0.85s
Check Time 10.36s (± 0.49%) 10.30s (± 0.27%) -0.06s (- 0.58%) 10.26s 10.33s
Emit Time 3.05s (± 0.87%) 3.06s (± 0.78%) +0.01s (+ 0.49%) 3.04s 3.10s
Total Time 16.05s (± 0.36%) 16.00s (± 0.18%) -0.05s (- 0.33%) 15.96s 16.03s
Monaco - node (v16.17.1, x64)
Memory used 343,253k (± 0.01%) 343,290k (± 0.01%) +37k (+ 0.01%) 343,258k 343,332k
Parse Time 3.18s (± 1.01%) 3.15s (± 1.18%) -0.02s (- 0.63%) 3.11s 3.21s
Bind Time 1.11s (± 0.95%) 1.11s (± 1.23%) +0.01s (+ 0.90%) 1.10s 1.14s
Check Time 7.74s (± 0.48%) 7.72s (± 0.66%) -0.02s (- 0.24%) 7.67s 7.82s
Emit Time 4.52s (± 0.74%) 4.53s (± 0.77%) +0.01s (+ 0.18%) 4.51s 4.60s
Total Time 16.55s (± 0.38%) 16.53s (± 0.32%) -0.02s (- 0.14%) 16.46s 16.62s
TFS - node (v16.17.1, x64)
Memory used 299,756k (± 0.00%) 299,750k (± 0.00%) -6k (- 0.00%) 299,738k 299,771k
Parse Time 2.47s (± 1.53%) 2.44s (± 0.84%) -0.03s (- 1.28%) 2.42s 2.47s
Bind Time 1.25s (± 0.60%) 1.25s (± 0.82%) +0.00s (+ 0.13%) 1.24s 1.27s
Check Time 7.18s (± 0.44%) 7.19s (± 0.50%) +0.00s (+ 0.02%) 7.17s 7.26s
Emit Time 4.24s (± 0.86%) 4.22s (± 0.83%) -0.02s (- 0.59%) 4.18s 4.28s
Total Time 15.15s (± 0.33%) 15.10s (± 0.48%) -0.05s (- 0.34%) 15.03s 15.23s
material-ui - node (v16.17.1, x64)
Memory used 476,064k (± 0.02%) 476,101k (± 0.02%) +37k (+ 0.01%) 475,986k 476,216k
Parse Time 3.71s (± 0.22%) 3.72s (± 0.34%) +0.01s (+ 0.13%) 3.70s 3.73s
Bind Time 1.02s (± 0.80%) 1.02s (± 0.00%) -0.00s (- 0.33%) 1.02s 1.02s
Check Time 18.16s (± 0.46%) 18.07s (± 0.48%) -0.09s (- 0.52%) 17.98s 18.21s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.90s (± 0.38%) 22.81s (± 0.34%) -0.09s (- 0.41%) 22.72s 22.93s
xstate - node (v16.17.1, x64)
Memory used 546,223k (± 0.02%) 546,250k (± 0.01%) +27k (+ 0.01%) 546,196k 546,406k
Parse Time 4.77s (± 0.28%) 4.76s (± 0.32%) -0.01s (- 0.24%) 4.74s 4.78s
Bind Time 1.83s (± 0.75%) 1.81s (± 3.79%) -0.03s (- 1.36%) 1.67s 1.84s
Check Time 2.97s (± 0.46%) 3.00s (± 2.53%) +0.04s (+ 1.29%) 2.97s 3.16s
Emit Time 0.10s (± 5.76%) 0.09s (± 5.53%) -0.00s (- 1.75%) 0.09s 0.10s
Total Time 9.67s (± 0.17%) 9.66s (± 0.19%) -0.00s (- 0.03%) 9.64s 9.69s
Angular - node (v14.15.1, x64)
Memory used 352,853k (± 0.00%) 352,849k (± 0.01%) -4k (- 0.00%) 352,826k 352,887k
Parse Time 4.24s (± 0.58%) 4.24s (± 0.57%) -0.00s (- 0.12%) 4.21s 4.28s
Bind Time 1.29s (± 0.63%) 1.28s (± 0.59%) -0.01s (- 0.39%) 1.27s 1.29s
Check Time 9.72s (± 0.38%) 9.70s (± 0.43%) -0.02s (- 0.21%) 9.63s 9.75s
Emit Time 8.40s (± 0.73%) 8.37s (± 0.39%) -0.03s (- 0.38%) 8.33s 8.42s
Total Time 23.64s (± 0.38%) 23.59s (± 0.23%) -0.06s (- 0.24%) 23.51s 23.67s
Compiler-Unions - node (v14.15.1, x64)
Memory used 190,178k (± 0.87%) 189,149k (± 0.06%) -1,029k (- 0.54%) 189,063k 189,384k
Parse Time 1.84s (± 0.49%) 1.84s (± 0.66%) +0.00s (+ 0.18%) 1.82s 1.85s
Bind Time 0.86s (± 0.73%) 0.86s (± 0.47%) +0.00s (+ 0.19%) 0.86s 0.87s
Check Time 10.37s (± 0.59%) 10.39s (± 0.77%) +0.02s (+ 0.18%) 10.31s 10.49s
Emit Time 3.46s (± 1.15%) 3.40s (± 3.73%) -0.06s (- 1.78%) 3.15s 3.50s
Total Time 16.54s (± 0.63%) 16.50s (± 0.51%) -0.04s (- 0.24%) 16.35s 16.61s
Monaco - node (v14.15.1, x64)
Memory used 338,019k (± 0.01%) 338,038k (± 0.00%) +19k (+ 0.01%) 338,023k 338,047k
Parse Time 3.22s (± 1.09%) 3.28s (± 1.24%) +0.06s (+ 1.81%) 3.23s 3.34s
Bind Time 1.11s (± 0.68%) 1.11s (± 0.00%) +0.00s (+ 0.15%) 1.11s 1.11s
Check Time 8.05s (± 0.26%) 8.06s (± 0.45%) +0.01s (+ 0.06%) 8.01s 8.10s
Emit Time 4.76s (± 0.39%) 4.75s (± 0.49%) -0.01s (- 0.21%) 4.72s 4.79s
Total Time 17.14s (± 0.26%) 17.20s (± 0.19%) +0.05s (+ 0.30%) 17.14s 17.23s
TFS - node (v14.15.1, x64)
Memory used 294,588k (± 0.01%) 294,609k (± 0.01%) +21k (+ 0.01%) 294,594k 294,632k
Parse Time 2.74s (± 0.72%) 2.74s (± 0.55%) -0.00s (- 0.06%) 2.73s 2.77s
Bind Time 1.11s (± 0.37%) 1.10s (± 0.74%) -0.01s (- 0.75%) 1.09s 1.11s
Check Time 7.50s (± 0.66%) 7.51s (± 0.37%) +0.01s (+ 0.11%) 7.47s 7.55s
Emit Time 4.60s (± 0.58%) 4.61s (± 0.93%) +0.01s (+ 0.18%) 4.58s 4.69s
Total Time 15.96s (± 0.36%) 15.96s (± 0.33%) -0.00s (- 0.03%) 15.91s 16.04s
material-ui - node (v14.15.1, x64)
Memory used 471,562k (± 0.00%) 471,566k (± 0.00%) +4k (+ 0.00%) 471,534k 471,595k
Parse Time 3.93s (± 0.71%) 3.93s (± 0.62%) -0.01s (- 0.17%) 3.90s 3.97s
Bind Time 1.04s (± 1.16%) 1.05s (± 0.49%) +0.00s (+ 0.32%) 1.04s 1.05s
Check Time 19.09s (± 0.74%) 19.03s (± 0.45%) -0.06s (- 0.31%) 18.92s 19.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 24.07s (± 0.67%) 24.01s (± 0.32%) -0.06s (- 0.24%) 23.90s 24.09s
xstate - node (v14.15.1, x64)
Memory used 534,443k (± 0.01%) 534,473k (± 0.00%) +31k (+ 0.01%) 534,441k 534,495k
Parse Time 5.17s (± 0.76%) 5.15s (± 0.81%) -0.02s (- 0.32%) 5.11s 5.22s
Bind Time 1.72s (± 1.13%) 1.72s (± 1.16%) +0.00s (+ 0.10%) 1.70s 1.75s
Check Time 3.10s (± 0.67%) 3.09s (± 0.35%) -0.01s (- 0.22%) 3.08s 3.10s
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) 0.00s ( 0.00%) 0.10s 0.10s
Total Time 10.08s (± 0.41%) 10.06s (± 0.49%) -0.02s (- 0.17%) 10.02s 10.15s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52466 6
Baseline main 6

TSServer

Comparison Report - main..52466
Metric main 52466 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,519ms (± 1.71%) 2,498ms (± 1.26%) -21ms (- 0.82%) 2,461ms 2,533ms
Req 2 - geterr 5,499ms (± 0.31%) 5,506ms (± 0.20%) +7ms (+ 0.13%) 5,490ms 5,517ms
Req 3 - references 365ms (± 0.89%) 365ms (± 1.17%) -0ms (- 0.05%) 356ms 368ms
Req 4 - navto 285ms (± 0.31%) 285ms (± 0.26%) -0ms (- 0.06%) 284ms 286ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 67ms (± 3.53%) 68ms (± 4.10%) +1ms (+ 1.24%) 65ms 71ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,739ms (± 1.36%) 2,755ms (± 1.06%) +16ms (+ 0.57%) 2,715ms 2,794ms
Req 2 - geterr 4,050ms (± 0.67%) 4,055ms (± 0.23%) +6ms (+ 0.14%) 4,047ms 4,073ms
Req 3 - references 367ms (± 0.64%) 368ms (± 0.58%) +2ms (+ 0.41%) 366ms 372ms
Req 4 - navto 299ms (± 1.09%) 299ms (± 0.66%) -1ms (- 0.22%) 295ms 300ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 82ms (± 1.09%) 82ms (± 3.52%) -0ms (- 0.41%) 76ms 84ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,487ms (± 0.42%) 3,485ms (± 0.48%) -3ms (- 0.07%) 3,457ms 3,505ms
Req 2 - geterr 1,418ms (± 1.53%) 1,427ms (± 1.49%) +10ms (+ 0.69%) 1,395ms 1,460ms
Req 3 - references 105ms (± 1.44%) 103ms (± 1.29%) -2ms (- 1.43%) 101ms 105ms
Req 4 - navto 357ms (± 0.42%) 355ms (± 0.87%) -2ms (- 0.47%) 351ms 360ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 466ms (± 1.25%) 464ms (± 2.09%) -2ms (- 0.36%) 455ms 476ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,764ms (± 0.85%) 2,782ms (± 0.51%) +18ms (+ 0.65%) 2,764ms 2,804ms
Req 2 - geterr 5,885ms (± 0.21%) 5,870ms (± 0.43%) -15ms (- 0.25%) 5,842ms 5,910ms
Req 3 - references 377ms (± 1.29%) 373ms (± 1.62%) -4ms (- 1.02%) 369ms 385ms
Req 4 - navto 278ms (± 0.97%) 279ms (± 0.42%) +1ms (+ 0.24%) 277ms 280ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 73ms (± 3.92%) 77ms (± 3.58%) +3ms (+ 4.32%) 71ms 78ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,936ms (± 0.47%) 2,927ms (± 0.21%) -10ms (- 0.32%) 2,917ms 2,935ms
Req 2 - geterr 4,396ms (± 0.40%) 4,395ms (± 0.39%) -1ms (- 0.02%) 4,375ms 4,417ms
Req 3 - references 379ms (± 1.15%) 380ms (± 0.52%) +1ms (+ 0.35%) 378ms 383ms
Req 4 - navto 288ms (± 0.36%) 286ms (± 0.46%) -1ms (- 0.46%) 284ms 287ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 72ms (± 1.05%) 72ms (± 1.63%) 0ms ( 0.00%) 71ms 74ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,629ms (± 0.54%) 3,621ms (± 0.30%) -8ms (- 0.21%) 3,601ms 3,633ms
Req 2 - geterr 1,564ms (± 1.09%) 1,562ms (± 0.93%) -2ms (- 0.12%) 1,538ms 1,580ms
Req 3 - references 110ms (± 0.96%) 111ms (± 2.04%) +1ms (+ 0.91%) 108ms 114ms
Req 4 - navto 342ms (± 1.03%) 341ms (± 0.78%) -0ms (- 0.05%) 338ms 346ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 478ms (± 0.68%) 480ms (± 1.43%) +2ms (+ 0.45%) 469ms 490ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,901ms (± 0.37%) 2,912ms (± 0.44%) +11ms (+ 0.37%) 2,898ms 2,931ms
Req 2 - geterr 6,284ms (± 0.32%) 6,272ms (± 0.80%) -12ms (- 0.19%) 6,201ms 6,339ms
Req 3 - references 391ms (± 0.55%) 389ms (± 0.19%) -2ms (- 0.38%) 388ms 390ms
Req 4 - navto 284ms (± 1.61%) 283ms (± 1.59%) -1ms (- 0.47%) 277ms 288ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 87ms (± 5.94%) 88ms (± 9.14%) +1ms (+ 0.96%) 72ms 93ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,094ms (± 1.33%) 3,079ms (± 0.22%) -15ms (- 0.49%) 3,072ms 3,087ms
Req 2 - geterr 4,703ms (± 0.47%) 4,692ms (± 0.39%) -11ms (- 0.23%) 4,673ms 4,726ms
Req 3 - references 404ms (± 1.28%) 405ms (± 0.92%) +1ms (+ 0.21%) 401ms 411ms
Req 4 - navto 292ms (± 0.79%) 291ms (± 0.81%) -2ms (- 0.57%) 288ms 294ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 80ms (± 0.94%) 82ms (± 3.61%) +2ms (+ 2.29%) 80ms 88ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,956ms (± 0.48%) 3,967ms (± 0.74%) +12ms (+ 0.29%) 3,938ms 4,015ms
Req 2 - geterr 1,543ms (± 1.69%) 1,524ms (± 1.66%) -20ms (- 1.26%) 1,487ms 1,559ms
Req 3 - references 133ms (± 0.88%) 130ms (± 3.32%) -3ms (- 2.50%) 123ms 135ms
Req 4 - navto 372ms (± 0.50%) 373ms (± 0.55%) +2ms (+ 0.49%) 370ms 376ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 508ms (± 1.43%) 500ms (± 2.50%) -8ms (- 1.64%) 484ms 513ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52466 6
Baseline main 6

Startup

Comparison Report - main..52466
Metric main 52466 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 141.87ms (± 0.22%) 142.01ms (± 0.16%) +0.14ms (+ 0.10%) 141.45ms 144.37ms
tsserver-startup - node (v16.17.1, x64)
Execution time 225.42ms (± 0.15%) 225.73ms (± 0.17%) +0.30ms (+ 0.13%) 224.85ms 232.10ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 227.96ms (± 0.17%) 228.27ms (± 0.21%) +0.31ms (+ 0.14%) 227.22ms 241.12ms
typescript-startup - node (v16.17.1, x64)
Execution time 208.91ms (± 0.18%) 209.27ms (± 0.16%) +0.36ms (+ 0.17%) 208.45ms 213.55ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52466 6
Baseline main 6

Developer Information:

Download Benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sandersn sandersn

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sandersn @typescript-bot @jakebailey @weswigham