gh-89727: Fix pathlib.Path.walk RecursionError on deep trees #100282
Conversation
|
| Name | Link |
|---|---|
| 2bfc47d | |
| https://app.netlify.com/sites/python-cpython-preview/deploys/639c50140be628000884140d |
|
TODO:
Update: |
…f github.com:ovsyanka83/cpython into pythongh-89727/fix-pathlib.Path.walk-recursion-depth
|
/cc @barneygale |
Lib/test/test_pathlib.py
Outdated
| path = pathlib.Path(base, *(['d']*50)) | ||
| path.mkdir(parents=True) | ||
|
|
||
| with infinite_recursion(40): |
There was a problem hiding this comment.
Now that it was merged in the os.walk PR, maybe use test.support.set_recursion_limit here? Although in practice the functionality is the same, the name infinite_recursion is inappropriate to this use and may confuse the reader regarding the purpose of the test (this test has nothing to do with infinite recursion.)
| with infinite_recursion(40): | |
| with set_recursion_limit(40): |
There was a problem hiding this comment.
Thank you! That was my intention all along to also use set_recursion_limit but I wanted to wait until it gets merged to prevent duplicate commits and possible merge conflicts that could arise if I did anything slightly differently.
|
@carljm remember that Path.walk has only been created in 3.12 which means that 99% of libraries/projects do not and cannot depend on it yet. |
Use a stack to implement pathlib.Path.walk iteratively instead of recursively to avoid hitting recursion limits on deeply nested trees.