Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BOLT as stable feature #101525

Open
1 of 6 tasks
corona10 opened this issue Feb 2, 2023 · 3 comments
Open
1 of 6 tasks

Make BOLT as stable feature #101525

corona10 opened this issue Feb 2, 2023 · 3 comments
Assignees
@corona10
Labels
performance Performance or resource usage type-feature A feature request or enhancement

Comments

@corona10
Copy link
Member

corona10 commented Feb 2, 2023 •
edited

Using a BOLT still not guarantee the unexpected behavior changes.
For example, I observed that #53093 is raised if the binary is optimized by BOLT.
We can reduce several too aggressive optimization.

  • Tune the optimization flags
  • Choose the APIs that should not be optimized BOLT (e.g -skip-funcs)
  • Update libregrtest.utils.get_build_info()
  • Update make test to work correctly (Should skip the BOLT phase if the binary is already BOLTed)
  • Define minimum LLVM version
  • Enhance the BOLT build process #101282

cc @aaupov

Linked PRs
@corona10 corona10 added type-feature A feature request or enhancement performance Performance or resource usage labels Feb 2, 2023
@corona10 corona10 self-assigned this Feb 2, 2023
@corona10
Copy link
Member Author

corona10 commented Feb 2, 2023

I am analyzing several effects of BOLT.

@corona10
Copy link
Member Author

corona10 commented Feb 8, 2023

Need to update get_build_info for the BOLT binary.

@corona10
Copy link
Member Author

corona10 commented Feb 24, 2023 •
edited

Consider a way to detect post-bolted binary: llvm/llvm-project#60253

corona10 added a commit to corona10/cpython that referenced this issue Apr 2, 2023
@corona10
pythongh-101525: Disable peephole optimization process of BOLT
16f15a1
@bedevere-bot bedevere-bot mentioned this issue Apr 2, 2023
Merged
corona10 added a commit that referenced this issue Apr 5, 2023
@corona10
gh-101525: Disable peephole optimization process of BOLT (gh-103187)
a62ff97 
Co-authored-by: Dong-hee Na <donghee.na@linecorp.com>
gaogaotiantian pushed a commit to gaogaotiantian/cpython that referenced this issue Apr 8, 2023
@corona10 @gaogaotiantian
pythongh-101525: Disable peephole optimization process of BOLT (pytho…
1614139 
…ngh-103187)


Co-authored-by: Dong-hee Na <donghee.na@linecorp.com>
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@corona10 @warsaw
pythongh-101525: Disable peephole optimization process of BOLT (pytho…
9ca78d7 
…ngh-103187)


Co-authored-by: Dong-hee Na <donghee.na@linecorp.com>
corona10 added a commit to corona10/cpython that referenced this issue Apr 16, 2023
@corona10
pythongh-101525: Fix make test if the --enable-bolt enabled
a9a36d5
@bedevere-bot bedevere-bot mentioned this issue Apr 16, 2023
Merged
corona10 added a commit that referenced this issue Apr 17, 2023
@corona10
gh-101525: Fix make test if the --enable-bolt enabled (gh-103574)
5d9762e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corona10 corona10

Labels
performance Performance or resource usage type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corona10