Skip to content

gh-101486: Make IsolatedAsyncioTestCase less picky about what is async [DO-NOT-MERGE] #101487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

gh-101486: Make IsolatedAsyncioTestCase less picky about what is async [DO-NOT-MERGE] #101487

wants to merge 5 commits into from

Conversation

zware
Copy link
Member

@zware zware commented Feb 1, 2023 •
edited by bedevere-bot
Loading

zware added 4 commits January 31, 2023 21:52
@zware
Add missing __unittest = True marker to async_case.py
00673f9
@zware
Remove out-of-date implementation comment
ab3633f
@zware
Run the entire test in the test context
f3eb654 
This is a broken commit; the `asyncioRunner.run` call raises a
`RuntimeError` because the context is already entered.  Not passing the
context to `asyncioRunner.run` results in test failures, but the tests
do actually run.
@zware
DO-NOT-MERGE: Hack around the inability to re-enter a running context
075971f
@bedevere-bot bedevere-bot mentioned this pull request Feb 1, 2023
Open
@zware zware added the skip news label Feb 1, 2023
@zware zware closed this Jan 11, 2024
@zware zware deleted the DNM-async_unittest_full_run_context branch January 11, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 will be requested when the pull request is marked ready for review 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov will be requested when the pull request is marked ready for review asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 will be requested when the pull request is marked ready for review kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc will be requested when the pull request is marked ready for review willingc is a code owner

Assignees
No one assigned
Labels
awaiting changes DO-NOT-MERGE skip news topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zware @willingc @bedevere-bot