Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl.OP_LEGACY_SERVER_CONNECT missing #89051

Closed
xtkoba mannequin opened this issue Aug 11, 2021 · 12 comments · Fixed by #93927
Closed

ssl.OP_LEGACY_SERVER_CONNECT missing #89051

xtkoba mannequin opened this issue Aug 11, 2021 · 12 comments · Fixed by #93927
Assignees
@tiran
Labels
3.10 3.11 3.12 expert-SSL

Comments

@xtkoba
Copy link
Mannequin

xtkoba mannequin commented Aug 11, 2021 •
edited by bedevere-bot

BPO 44888
Nosy @tiran, @xtkoba
PRs
  • bpo-44888: Add ssl.OP_LEGACY_SERVER_CONNECT #27776
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = None
created_at = <Date 2021-08-11.11:35:40.075>
labels = ['expert-SSL']
title = 'ssl.OP_LEGACY_SERVER_CONNECT missing'
updated_at = <Date 2021-08-16.03:58:50.811>
user = 'https://github.com/xtkoba'

    bugs.python.org fields:

    activity = <Date 2021-08-16.03:58:50.811>
actor = 'python-dev'
assignee = 'christian.heimes'
closed = False
closed_date = None
closer = None
components = ['SSL']
creation = <Date 2021-08-11.11:35:40.075>
creator = 'xtkoba'
dependencies = []
files = []
hgrepos = []
issue_num = 44888
keywords = ['patch']
message_count = 1.0
messages = ['399386']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'python-dev', 'xtkoba']
pr_nums = ['27776']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue44888'
versions = []

    Linked PRs
    @xtkoba
    Copy link
    Mannequin Author

    xtkoba mannequin commented Aug 11, 2021

    Please implement ssl.OP_LEGACY_SERVER_CONNECT constant that corresponds to SSL_OP_LEGACY_SERVER_CONNECT in C. This is required to make OpenSSL 3.0.0 behave like 1.1.1.

    @xtkoba xtkoba mannequin assigned tiran Aug 11, 2021
    @xtkoba xtkoba mannequin added the expert-SSL label Aug 11, 2021
    @xtkoba xtkoba mannequin assigned tiran Aug 11, 2021
    @xtkoba xtkoba mannequin added the expert-SSL label Aug 11, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @graingert graingert mentioned this issue Jun 17, 2022
    Merged
    graingert added a commit to graingert/cpython that referenced this issue Jun 17, 2022
    @graingert
    Add ssl.OP_LEGACY_SERVER_CONNECT
    99125e8 
    Fixes python#89051
    @tiran
    Copy link
    Member

    tiran commented Aug 3, 2022

    @graingert Do you want to backport the change to 3.11 and 3.10?

    @graingert
    Copy link
    Contributor

    graingert commented Aug 3, 2022

    @graingert Do you want to backport the change to 3.11 and 3.10?

    I'd like the backport in 3.10 and I hope the patch will apply automatically

    @tiran
    Copy link
    Member

    tiran commented Aug 3, 2022

    I'd like the backport in 3.10 and I hope the patch will apply automatically

    You have to manually backport the patch to 3.11 and 3.11 to adjust the versionadded field.

    @graingert
    Copy link
    Contributor

    graingert commented Aug 3, 2022

    oh right so it should be versionadded: 3.10.6, 3.11 in the original PR?

    @tiran
    Copy link
    Member

    tiran commented Aug 3, 2022

    The original PR should have 3.11 and the backport to 3.10 needs to have 3.10.7. AFAIK versionadded does only support one argument.

    @graingert
    Copy link
    Contributor

    graingert commented Aug 3, 2022

    Hmm but then users reading the 3.11 docs will see the wrong versionadded

    cc @hugovk

    @hugovk
    Copy link
    Member

    hugovk commented Aug 3, 2022

    So was it added in 3.11 and backported to 3.10.6?

    Can it be .. versionadded:: 3.10.6 for both?

    Otherwise, https://devguide.python.org/documentation/markup/?highlight=versionadded#paragraph-level-markup says of versionadded:

    The first argument must be given and is the version in question. The second argument is optional and can be used to describe the details of the feature.

    For example:

    hugovk pushed a commit that referenced this issue Dec 20, 2022
    @graingert
    gh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (#93927)
    79ccc03 
    Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Fixes #89051
    @hugovk
    Copy link
    Member

    hugovk commented Dec 20, 2022

    I've merged #93927 with:

    • .. versionadded:: 3.12 in 3.12/main

    And let's go for:

    • .. versionadded:: 3.10.10 in 3.10
    • .. versionadded:: 3.11.2 in 3.11

    @graingert Please could you make the 3.10 and 3.11 backport PRs?

    @hugovk hugovk reopened this Dec 20, 2022
    @hugovk
    Copy link
    Member

    hugovk commented Dec 20, 2022

    Actually, let's try using Miss Islington and then modify those PRs.

    hugovk pushed a commit to hugovk/cpython that referenced this issue Dec 20, 2022
    @graingert @hugovk
    pythongh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (python#93927)
    dd21351 
    Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Fixes python#89051

(cherry picked from commit 79ccc03)
    This was referenced Dec 20, 2022
    Closed
    Closed
    @hugovk
    Copy link
    Member

    hugovk commented Dec 20, 2022

    Miss Islington didn't like the merge conflicts, back to the command line. Please see PRs #100359 and #100360.

    jonburdo pushed a commit to jonburdo/cpython that referenced this issue Dec 20, 2022
    @graingert @jonburdo
    pythongh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (python#93927)
    33ba6a5 
    Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Fixes python#89051
    @hugovk
    Copy link
    Member

    hugovk commented Dec 21, 2022

    I closed the backports, as we don't normally backport new features to bugfix branches.

    https://devguide.python.org/versions/

    This will be in the next 3.12.0 alpha 4, due on 2023-01-09.

    @hugovk hugovk closed this as completed Dec 21, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    3.10 3.11 3.12 expert-SSL
    Projects
    OpenSSL 3
    Status: Done
    Milestone
    No milestone
    Development

    Successfully merging a pull request may close this issue.

    gh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT graingert/cpython
    3 participants
    @graingert @tiran @hugovk