gh-99482: remove jython compatibility parts from stdlib and tests
#99484
+136
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
commented
Nov 14, 2022
| @@ -321,7 +321,7 @@ def raises_oserror(*a): | |||
|
|
|||
| def test_java_ver(self): | |||
| res = platform.java_ver() | |||
There was a problem hiding this comment.
I am not touching platform.java_ver(), because this is a user-facing API.
| def __repr__(self): | ||
| return b'byte-repr' | ||
| self.assertRaises(TypeError, repr, WrongRepr()) | ||
| # Test basic sanity of repr() |
There was a problem hiding this comment.
These diffs are ugly, I can do if True: instead with a comment.
sobolevn
commented
Nov 14, 2022
| @@ -360,10 +360,9 @@ def test_capi3(): | |||
| self.assertRaises(SystemError, _testcapi.raise_exception, | |||
| InvalidException, 1) | |||
|
|
|||
| if not sys.platform.startswith('java'): | |||
There was a problem hiding this comment.
This is not required, because there's @cpython_only decorator.
| pyc = TESTFN + "$py.class" | ||
| else: | ||
| pyc = TESTFN + ".pyc" | ||
| pyc = TESTFN + ".pyc" |
There was a problem hiding this comment.
I am removing Jython compat from tests, because there are lots and lots of new tests since 2.7
New syntax, new corner cases, etc.
If Jython ever run our new suite, there will be a lot of things to fix / adapt on their side.
hauntsaninja
reviewed
Dec 23, 2022
hauntsaninja
reviewed
Dec 23, 2022
JelleZijlstra
approved these changes
Dec 23, 2022
| def __repr__(self): | ||
| return b'byte-repr' | ||
| self.assertRaises(TypeError, ascii, WrongRepr()) | ||
| # Test basic sanity of repr() |
There was a problem hiding this comment.
Not related to your PR but this comment seems wrong.
There was a problem hiding this comment.
I will take care of it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I am marking this a draft for now, because we still wait for Jython's team response.
But, it is always easier to make decisions when you see the code :)