Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memory_iterator #4138

Merged
merged 3 commits into from Aug 29, 2022
Merged

Add memory_iterator #4138

merged 3 commits into from Aug 29, 2022
+69 −6

Conversation

jopemachine
Copy link
Contributor

@jopemachine jopemachine commented Aug 28, 2022 •
edited

Added memory_iterator type implemented in python 3.10

Refereneces

bpo-41732: Added an iterator to memoryview.

youknowone
youknowone reviewed Aug 28, 2022
View changes
vm/src/builtins/memory.rs Outdated Show resolved Hide resolved
youknowone
youknowone reviewed Aug 28, 2022
View changes
whats_left.py Outdated Show resolved Hide resolved
@jopemachine jopemachine marked this pull request as ready for review Aug 28, 2022
@youknowone youknowone added the zca-2022 Tag to track contrubution-academy 2022 label Aug 29, 2022
youknowone
youknowone approved these changes Aug 29, 2022
View changes
Copy link
Member

@youknowone youknowone left a comment

I left a few style change requests. Other parts looks great, thank you!

vm/src/builtins/memory.rs Outdated Show resolved Hide resolved
vm/src/builtins/memory.rs Outdated Show resolved Hide resolved
@youknowone youknowone merged commit ef4bea5 into RustPython:main Aug 29, 2022
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone

Assignees
No one assigned
Labels
zca-2022 Tag to track contrubution-academy 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jopemachine @youknowone