[VarExporter] Fix lazy-proxying readonly classes on PHP 8.3 #49282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
ve-readonly-proxy
branch
3 times, most recently
from
849bd8a
to
a26eb01
Compare
nicolas-grekas
force-pushed
the
ve-readonly-proxy
branch
from
a26eb01
to
5ea5ea8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Now that https://wiki.php.net/rfc/readonly_amendments has been accepted, I figured out the design of
LazyProxyTraitneeds some tweaks to support readonly classes.This basically move the
LazyProxyTrait::$lazyObjectRealproperty toLazyObjectState::$realInstance.