[Notifier] Fix notifier profiler when transport name is null #49326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
commented
Feb 10, 2023
| @@ -24,7 +24,7 @@ class NotificationEvents | |||
| public function add(MessageEvent $event): void | |||
| { | |||
| $this->events[] = $event; | |||
| $this->transports[$event->getMessage()->getTransport()] = true; | |||
| $this->transports[(string) $event->getMessage()->getTransport()] = true; | |||
There was a problem hiding this comment.
null is anyway converted to an empty string by PHP. Let's be explicit here.
nicolas-grekas
reviewed
Feb 11, 2023
| @@ -43,7 +43,7 @@ public function getEvents(string $name = null): array | |||
|
|
|||
| $events = []; | |||
| foreach ($this->events as $event) { | |||
| if ($name === $event->getMessage()->getTransport()) { | |||
| if ($name === (string) $event->getMessage()->getTransport()) { | |||
There was a problem hiding this comment.
not sure about this one: do we support the empty string as transport name?
|
Thank you @fabpot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When the transport name is
null, the profiler is currently broken (JS error).