Skip to content

[Filesystem] Remove always true condition #49341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2023
Merged

[Filesystem] Remove always true condition #49341

merged 1 commit into from
Feb 13, 2023

Conversation

alamirault
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

$mode is type hinted int $mode, so this condition is always true.

@carsonbot carsonbot added this to the 6.3 milestone Feb 12, 2023
@alamirault alamirault mentioned this pull request Feb 12, 2023
Merged
@nicolas-grekas
Copy link
Member

Thank you @alamirault.

@nicolas-grekas nicolas-grekas merged commit f3dbf6c into symfony:6.3 Feb 13, 2023
@alamirault alamirault deleted the feature/remove-always-true-condition branch February 13, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@fancyweb fancyweb fancyweb approved these changes

Assignees
No one assigned
Labels
Filesystem Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@alamirault @nicolas-grekas @OskarStark @fancyweb @carsonbot