Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Remove redundant code from logger template #48046

Merged

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Oct 29, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Introduced in #42195, the log trace gets unnecessarily rendered twice:

image

@carsonbot
Copy link

carsonbot commented Oct 30, 2022

Hey!

I think @Amunak has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@derrabus
Copy link
Member

derrabus commented Oct 31, 2022

@javiereguiluz Can you have a look?

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Sorry I missed this. Thanks for fixing this issue!

stof
stof approved these changes Nov 30, 2022
fabpot
fabpot approved these changes Dec 1, 2022
@fabpot
Copy link
Member

fabpot commented Dec 1, 2022

Thank you @HypeMC.

@fabpot fabpot merged commit 68e3261 into symfony:5.4 Dec 1, 2022
9 of 11 checks passed
@HypeMC HypeMC deleted the remove-redundant-code-from-logger-template branch Dec 1, 2022
@fabpot fabpot mentioned this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants