[Feature #18915] Scope change for NotImplementedError
#7201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates documentation for NotImplementedError to consider raising it valid when a defined method is not implemented because it is designed to be abstract and overriden in a subclass.
W-Mills
force-pushed
the
18915-change-documented-scope-of-NotImplementedError
branch
from
16cc2b7
to
8713c13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Issue
Resolves https://bugs.ruby-lang.org/issues/18915
Description
Updates documentation for
NotImplementedErrorto expand its defined usage to include when a method is not implemented because it's designed to be abstract and overridden in a subclass.Context
There is currently no semantically correct error to raise when an abstract method is defined, but designed to be implemented in a subclass only.
NoMethodErroris incorrect because there is a method defined (used to declare a common interface).Given the existing widespread adoption of
NotImplementedErrorfor this scenario, this PR simply updates the definition to consider it valid usage.Alternative Approach Considered
I debated creating a new
MustOverrideErrorthat inherits fromStandardErrorbut opted to expand the scope ofNotImplementedErrorgiven the existing adoption and semantic correctness.