Skip to content

gh-101879: docs - italicize argument in smtplib.SMPT() description #101886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2023
Merged

gh-101879: docs - italicize argument in smtplib.SMPT() description #101886

merged 3 commits into from
Apr 26, 2023

Conversation

OTheDev
Copy link
Contributor

@OTheDev OTheDev commented Feb 13, 2023 •
edited by bedevere-bot
Loading

@OTheDev OTheDev requested a review from a team as a code owner February 13, 2023 19:39
@bedevere-bot bedevere-bot mentioned this pull request Feb 13, 2023
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Feb 13, 2023
terryjreedy
terryjreedy requested changes Feb 13, 2023
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 28, 'host' and 'port' should also be italicized.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@terryjreedy terryjreedy added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes triaged The issue has been accepted as valid by a triager. and removed triaged The issue has been accepted as valid by a triager. labels Feb 13, 2023
@OTheDev
Copy link
Contributor Author

OTheDev commented Feb 13, 2023

@terryjreedy Thanks! I found other instances too that I'll change.

@OTheDev
Copy link
Contributor Author

OTheDev commented Feb 13, 2023

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@hugovk hugovk removed the needs backport to 3.10 only security fixes label Apr 7, 2023
hugovk
hugovk approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I also removed the 3.10 backport label because it now only accepts security fixes.

hauntsaninja
hauntsaninja approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@erlend-aasland
Copy link
Contributor

AFAICS, @terryjreedy's remarks have been addressed.

@erlend-aasland erlend-aasland merged commit 28a05f4 into python:main Apr 26, 2023
@miss-islington
Copy link
Contributor

Thanks @OTheDev for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2023
@OTheDev @miss-islington
pythongh-101879: docs - italicize argument in smtplib.SMPT() descript…
c46f36e 
…ion (pythonGH-101886)

(cherry picked from commit 28a05f4)

Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
@bedevere-bot
Copy link

GH-103888 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 26, 2023
terryjreedy pushed a commit that referenced this pull request Apr 26, 2023
@miss-islington @OTheDev
[3.11] gh-101879: docs - italicize argument in smtplib.SMPT() descrip…
bce93c2 
…tion (GH-101886) (#103888)

gh-101879: docs - italicize argument in smtplib.SMPT() description (GH-101886)
(cherry picked from commit 28a05f4)

Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
itamaro pushed a commit to itamaro/cpython that referenced this pull request Apr 26, 2023
@OTheDev @itamaro
pythongh-101879: docs - italicize argument in smtplib.SMPT() descript…
f6881d5 
…ion (python#101886)
@OTheDev OTheDev deleted the fix-issue-101879 branch January 28, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for smtplib Missing Italics
7 participants
@OTheDev @bedevere-bot @erlend-aasland @miss-islington @hugovk @hauntsaninja @terryjreedy