New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-101578: Amend PyErr_{Set,Get}RaisedException docs #101962
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @erlend-aasland ; this is a substantial improvement to the previous docs.
Perhaps its worth fixing the other couple remaining similar docs defects also introduced in PR #101607 , namely in the descriptions of the newly documented functions PyException_GetArgs
and PyException_SetArgs
(that could use a similar (if much simpler) treatment as here), and the deprecation notices added to PyErr_Fetch
, PyErr_Restore
and PyErr_NormalizeException
not being added to, and particularly duplicating, the .. deprecated
directive.
Thanks, and thanks for the review!
Definitely; perhaps as a follow-up PR? |
Yeah certainly could be; up to you, of course |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple followup suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from me; thanks @erlend-aasland !
Thanks for the review, CAM; highly appreciated. I'll wait for @iritkatriel's or @markshannon's approval before landing. |
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Thanks for the reviews, Irit and CAM; highly appreciated. I'll create a follow-up PR Any Time Soon™. |
Follow-up to pythongh-101962
PyErr_SetObject()
behavior is strange and not as documented. #101578