Fix typos in variable names, function names, and comments #101868
Conversation
howjmay
requested review from
a team,
pablogsal,
lysnikolaou,
pganssle,
abalkin,
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
| @@ -1490,7 +1490,7 @@ def packageFromRecipe(targetDir, recipe): | |||
| IFPkgFlagRelocatable=False, | |||
| IFPkgFlagRestartAction="NoRestart", | |||
| IFPkgFlagRootVolumeOnly=True, | |||
| IFPkgFlagUpdateInstalledLangauges=False, | |||
| IFPkgFlagUpdateInstalledLanguages=False, | |||
There was a problem hiding this comment.
@python/macos-team Looks like a potentially impactful change here. Can you review?
There was a problem hiding this comment.
This looks like a bug fix to me. If someone could demonstrate undesired behavior caused by this typo, it would warrant a bug report and a separate PR.
There was a problem hiding this comment.
FTR, Ned responded here: #101868 (review)
| @@ -522,7 +522,7 @@ def gcc_get_limited_api_macros(headers): | |||
|
|
|||
| api_hexversion = sys.version_info.major << 24 | sys.version_info.minor << 16 | |||
|
|
|||
| preprocesor_output_with_macros = subprocess.check_output( | |||
There was a problem hiding this comment.
Not sure who the current maintainer here would be (@encukou?) but someone should check that all references have been handled.
There was a problem hiding this comment.
Yeah, me. I won't get to reviewing a typo in an internal variable name any time soon though. Generally we avoid such cosmetic changes, anyway.
|
Can this PR be merged? |
|
Not yet, there's still some open questions. |
Oleg, please check all conversations and posts on the issue before adding adding comments like this. As the devguide says, please be patient. I know you only want to help, but comments like this can end up being more noise than help (and this PR is already balancing on the edge wrt. churn vs. real issues). It's easy to see, for example, that Ned's remark has not been addressed yet (read the post, check the diff). Petr's comment hints of a -1 for that particular change, so IMO the PR author should avoid that too. (Hope this did not come out too harsh.) |
erlend-aasland
changed the title
|
Also, only straight-forward documentation fixes generally get the skip issue label. Renaming a variable or a function can potentially be a breaking change, so personally I would not apply the skip issue label to such a PR. FWIW. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All these changes LGTM. Changing comments, names of local variables and internal functions in internal modules is pretty safe. The only change that can potentially have effect is the change in |
No description provided.