Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-100942: Fix incorrect cast in property_copy(). #100965

Merged
merged 2 commits into from Jan 12, 2023
Merged

GH-100942: Fix incorrect cast in property_copy(). #100965

merged 2 commits into from Jan 12, 2023

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Jan 12, 2023 •
edited by bedevere-bot

@bedevere-bot bedevere-bot mentioned this pull request Jan 12, 2023
Open
sobolevn
sobolevn approved these changes Jan 12, 2023
View changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice to see that my idea in #100955 was correct.
I will close mine, since you probably haven't seen it :)

Lib/test/test_property.py
pass

p = property.__new__(pro)
p.__set_name__(A, 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not really required. Segfault happens and without it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to leave it because it covers an additional code path that could fail and it is an accurate record of how the issue was discovered.

@sobolevn sobolevn added type-crash A hard crash of the interpreter, possibly with a core dump and removed type-bug An unexpected behavior, bug, or error labels Jan 12, 2023
@rhettinger rhettinger merged commit 94fc770 into python:main Jan 12, 2023
17 checks passed
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @rhettinger, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 94fc7706b7bc3d57cdd6d15bf8e8c4499ae53a69 3.11

@miss-islington
Copy link
Contributor

Sorry @rhettinger, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 94fc7706b7bc3d57cdd6d15bf8e8c4499ae53a69 3.10

@rhettinger
Copy link
Contributor Author

@sobolevn Would you like to take care of the backport. This PR won't apply cleanly and needs to be recreated for 3.11 and prior.

@sobolevn
Copy link
Member

Yeah, why not :)
Will do soon!

sobolevn pushed a commit to sobolevn/cpython that referenced this pull request Jan 13, 2023
@rhettinger @sobolevn
[3.11] pythonGH-100942: Fix incorrect cast in property_copy(). (pytho…
e42fbf0 
…nGH-100965).

(cherry picked from commit 94fc770)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-bot
Copy link

GH-101008 is a backport of this pull request to the 3.11 branch.

sobolevn pushed a commit to sobolevn/cpython that referenced this pull request Jan 13, 2023
@rhettinger @sobolevn
[3.10] pythonGH-100942: Fix incorrect cast in property_copy(). (pytho…
4871a93 
…nGH-100965).

(cherry picked from commit 94fc770)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-bot
Copy link

GH-101009 is a backport of this pull request to the 3.10 branch.

@sobolevn
Copy link
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn

Assignees

@rhettinger rhettinger

Labels
type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhettinger @miss-islington @sobolevn @bedevere-bot