Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in the Objects directory #28766

Merged
merged 1 commit into from Oct 6, 2021
Merged

Fix typos in the Objects directory #28766

merged 1 commit into from Oct 6, 2021

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 6, 2021 •
edited by miss-islington

Like #28744 but for the Objects directory.

[skip issue] Opening a related issue is pending python/psf-infra-meta#130

Automerge-Triggered-By: GH:gpshead
@cclauss
Fix typos in the Objects directory
a28cdf4
@gpshead gpshead self-assigned this Oct 6, 2021
@gpshead
Copy link
Member

@gpshead gpshead commented Oct 6, 2021

There are ~5 of these PRs, see #28745 (comment) for details on how we're handling them. TL;DR - I'm taking the reviews. Backports to 3.9 and 3.10 are being done (manually) to reduce potential for merge conflicts of other bugfix backports.

gpshead
gpshead approved these changes Oct 6, 2021
View changes
@gpshead gpshead closed this Oct 6, 2021
@gpshead gpshead reopened this Oct 6, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 6, 2021

@cclauss: Status check is done, and it's a success ❌ .

@gpshead gpshead merged commit 5f401f1 into python:main Oct 6, 2021
18 of 19 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 6, 2021

Thanks @cclauss for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 6, 2021

Sorry, @cclauss and @gpshead, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5f401f10400123afa9171548c432ea3fc37c0736 3.10

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 6, 2021

Sorry @cclauss and @gpshead, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 5f401f10400123afa9171548c432ea3fc37c0736 3.9

@cclauss cclauss deleted the codespell-Objects branch Oct 7, 2021
@cclauss cclauss mentioned this pull request Oct 7, 2021
Merged
cclauss added a commit to cclauss/cpython that referenced this issue Oct 7, 2021
@cclauss
[3.9] Fix typos in the Objects directory (pythonGH-28766)
84e900e 
(cherry picked from commit 5f401f1)
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 7, 2021

GH-28795 is a backport of this pull request to the 3.9 branch.

cclauss added a commit to cclauss/cpython that referenced this issue Oct 7, 2021
@cclauss
[3.10] Fix typos in the Objects directory (pythonGH-28766)
eceefbb 
(cherry picked from commit 5f401f1)
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 7, 2021

GH-28797 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit that referenced this issue Oct 7, 2021
@cclauss
[3.9] Fix typos in the Objects directory (GH-28766) (GH-28795)
960e7b3 
(cherry picked from commit 5f401f1)

Automerge-Triggered-By: GH:JulienPalard
miss-islington pushed a commit that referenced this issue Oct 7, 2021
@cclauss
[3.10] Fix typos in the Objects directory (GH-28766) (GH-28797)
dcfbe4f 
(cherry picked from commit 5f401f1)

Automerge-Triggered-By: GH:JulienPalard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

@lysnikolaou lysnikolaou

@markshannon markshannon

@pablogsal pablogsal

@rhettinger rhettinger

@python/windows-team windows-team

Assignees

@gpshead gpshead

Labels
CLA signed 🤖 automerge skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@cclauss @gpshead @miss-islington @bedevere-bot @the-knights-who-say-ni