Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT]: FFMpegWriter does not check if out path exists when initialized. #25233

Closed
waltsims opened this issue Feb 16, 2023 · 0 comments · Fixed by #25238
Closed

[MNT]: FFMpegWriter does not check if out path exists when initialized. #25233

waltsims opened this issue Feb 16, 2023 · 0 comments · Fixed by #25238

Comments

@waltsims
Copy link

Summary

FFMpegWriter does not ensure the outputpath exists when initialized (here). This leads to a broken pipe error with no mention of a non-existent path which can be misleading to the user.

Proposed fix

When setup is called, check the output path exists and if not, throw an error to inform the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants