Skip to content

/ Chart.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up easing functions #8518

Merged
merged 2 commits into from Feb 24, 2021
Merged

Clean up easing functions #8518

merged 2 commits into from Feb 24, 2021
+60 −173

Conversation

@kurkle
Copy link
Collaborator

@kurkle kurkle commented Feb 24, 2021

Convert most of the easing functions to compact arrow notation, reduce duplication
@kurkle
Clean up easing functions
Verified
This commit was signed with a verified signature.
kurkle Jukka Kurkela
GPG key ID: 3EEC947987C7AD85 Learn about signing commits
Loading status checks…
be48838
@kurkle kurkle added the type: chore label Feb 24, 2021
@LeeLenaleee
LeeLenaleee reviewed Feb 24, 2021
View changes
src/helpers/helpers.easing.js Show resolved Hide resolved
@benmccann
benmccann reviewed Feb 24, 2021
View changes
src/helpers/helpers.easing.js Outdated Show resolved Hide resolved
@benmccann
benmccann reviewed Feb 24, 2021
View changes
src/helpers/helpers.easing.js Show resolved Hide resolved
@kurkle
Remove leftover comment
Verified
This commit was signed with a verified signature.
kurkle Jukka Kurkela
GPG key ID: 3EEC947987C7AD85 Learn about signing commits
Loading status checks…
d8fdce3
@etimberg
etimberg reviewed Feb 24, 2021
View changes
src/helpers/helpers.easing.js Show resolved Hide resolved
src/helpers/helpers.easing.js Show resolved Hide resolved
@etimberg
etimberg approved these changes Feb 24, 2021
View changes
@kurkle
Copy link
Collaborator Author

@kurkle kurkle commented Feb 24, 2021

Filename Size Change
dist/chart.esm.js 65.7 kB +43 B (0%)
dist/chart.js 83.3 kB +55 B (0%)
dist/chart.min.js 59.3 kB +29 B (0%)
dist/chunks/helpers.segment.js 18.7 kB +5 B (0%)

Had to check the uncompressed sizes:

Filename Size Change
chart.js 358 kB -1092 B
chart.min.js 169 kB -190 B
@etimberg etimberg merged commit 53ea370 into chartjs:master Feb 24, 2021
10 checks passed
10 checks passed
build (ubuntu-latest)
Details
build
Details
build (windows-latest)
Details
finish
Details
Coveralls - ubuntu-latest-chrome Coverage increased (+0.05%) to 94.965%
Details
Coveralls - ubuntu-latest-firefox Coverage increased (+0.06%) to 94.861%
Details
Coveralls - windows-latest-chrome Coverage increased (+0.05%) to 94.965%
Details
Coveralls - windows-latest-firefox Coverage increased (+0.03%) to 94.846%
Details
codeclimate 5 fixed issues
Details
coverage/coveralls Coverage increased (+0.05%) to 94.965%
Details
@etimberg etimberg added this to the Version 3.0 milestone Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann

@LeeLenaleee LeeLenaleee

@etimberg etimberg

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 3.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@kurkle @benmccann @etimberg @LeeLenaleee