Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL used in binary builds needs updating for CVE-2023-0286 #101726

Open
gpshead opened this issue Feb 9, 2023 · 2 comments
Open

OpenSSL used in binary builds needs updating for CVE-2023-0286 #101726

gpshead opened this issue Feb 9, 2023 · 2 comments
Assignees
Labels
release-blocker type-bug An unexpected behavior, bug, or error type-security A security issue

Comments

@gpshead gpshead added type-bug An unexpected behavior, bug, or error type-security A security issue release-blocker labels Feb 9, 2023
gpshead added a commit to gpshead/cpython that referenced this issue Feb 9, 2023
@zooba
Copy link
Member

zooba commented Feb 9, 2023

My read of the impact to us:

  • CVE-2023-0286 requires users to enable CRL checking, as it appears that we don't do anything besides provide the constants. Also, from the advisory: "In most cases, the attack requires the attacker to provide both the certificate chain and CRL", which suggests a more appropriate mitigation (don't use an attacker's revocation list :) )
  • CVE-2022-4304 is a timing oracle requiring a very large number of requests. I suspect natural variation would make this infeasible over an actual network, but if it can be demoed, this seems like the biggest issue for us.
  • CVE-2022-4203 requires a CA-signed certificate, and at worst may cause a crash. In any case, doesn't impact OpenSSL 1.1
  • CVE-2023-0215 and CVE-2023-4450 impact BIO_new_NDEF and PEM_read_bio_ex which we neither use nor expose
  • Remaining issues don't affect 1.1

So I think the only concerning one is the timing oracle, and it doesn't concern me enough to trigger a new round of releases.

However, I'm also concerned by the near certainty that we'll be criticised (again) for not immediately reacting, so if we'd rather not keep patiently explaining to nervous people that we aren't impacted, we could schedule new releases.

zooba pushed a commit that referenced this issue Feb 9, 2023
zooba pushed a commit to zooba/cpython that referenced this issue Feb 9, 2023
zooba pushed a commit to zooba/cpython that referenced this issue Feb 9, 2023
zooba pushed a commit to zooba/cpython that referenced this issue Feb 9, 2023
@gpshead
Copy link
Member Author

gpshead commented Feb 9, 2023

Thanks for the analysis Steve!

I agree, this doesn't currently sound like an urgent priority to release. (ie: apparently not a "Critical - everyone is screwed" flaw). It's good to have the commits/PRs ready place so that we can; thanks everyone for jumping on those.

I expect some people will want it sooner than our next planned releases in April because noteworthy CVEs do tend to trigger non-technical requirements for people to upgrade their software. At least it doesn't feel like we need to rush to cut new releases this week. 😅

zooba added a commit that referenced this issue Feb 9, 2023
Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt

---------

Co-authored-by: Gregory P. Smith <greg@krypto.org>
zooba added a commit that referenced this issue Feb 9, 2023
Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt

Co-authored-by: Gregory P. Smith <greg@krypto.org>
ned-deily added a commit that referenced this issue Feb 9, 2023
…-101753)

Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Ned Deily <nad@python.org>
carljm added a commit to carljm/cpython that referenced this issue Feb 10, 2023
* main:
  Fix some typos in asdl_c.py (pythonGH-101757)
  pythongh-101747: Fix refleak in new `OrderedDict` repr (pythonGH-101748)
  pythongh-101430: Update tracemalloc to handle presize properly. (pythongh-101745)
  pythonGH-101228: Fix typo in docstring for read method of `_io.TextIOWrapper` class (python#101227)
  Fix typo in `test_fstring.py` (python#101600)
  pythongh-101726: Update the OpenSSL version to 1.1.1t (pythonGH-101727)
  pythongh-101283: Fix 'versionchanged' for the shell=True fallback on Windows in 3.12 (pythonGH-101728)
  LibFFI build requires x64 Cygwin, and skip the ARM build (pythonGH-101743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker type-bug An unexpected behavior, bug, or error type-security A security issue
Projects
Status: Todo
Development

No branches or pull requests

4 participants