Skip to content

Partest toolargs caching [ci: last-only] #10287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2023

Conversation

som-snytt
Copy link
Contributor

Reduce reading/parsing of partest "toolArgs" from test headers.

Supported "tool" names are enumerated (as in dotty, the thought leader). Only "filter" is unparsed.

Note "javaVersion" is only used as a lower bound, "19+", as in dotty, the thought leader, so for simplicity [sic] a range must be written without spaces, "11-19".

@scala-jenkins scala-jenkins added this to the 2.13.11 milestone Jan 31, 2023
@som-snytt som-snytt added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Jan 31, 2023
@SethTisue
Copy link
Member

Could/should this be a single commit? It wasn't obvious to me as reviewer that these were distinct chapters of a story, except maybe the usual "in the end I got it working" story :-)

@som-snytt
Copy link
Contributor Author

I didn't want anybody's 🤯 as it is a lot to take in.

@som-snytt
Copy link
Contributor Author

also, I've started ci: last-only if I sense that I will squash later. Reviewer can review all changes at once, per pleasure. Don't be fooled by the fact that only one file changed! Partest is basically one file now.

@SethTisue SethTisue self-assigned this Feb 20, 2023
@SethTisue SethTisue merged commit 122de8d into scala:2.13.x Mar 13, 2023
@som-snytt
Copy link
Contributor Author

@SethTisue you were correct, I intended to squash after review. Other PRs are unsquashed. I'll wait a while to give you time to tell me if you have an opinion on whether I should pre-squash; otherwise I will go ahead and squash in the interest of time.

@som-snytt som-snytt deleted the partest/toolargs-caching branch March 13, 2023 22:56
@som-snytt
Copy link
Contributor Author

@SethTisue this PR has a semantic conflict and causes a compile error in partest. I will dispatch a PR to fix.

@SethTisue
Copy link
Member

I will dispatch a PR to fix.

I beat you to it

I intended to squash after review

no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants