steps to reproduce

Write a loop, from 1 to 80000, each time add a random int to the max heap.

In theory it takes very little time(NlogN, N=80000, <1sec ), but the program does take a long time.

I'v also tested the BinaryHeap in https://github.com/SolutionsDesign/Algorithmia, it performs well, so it is probably due to the bad algorithm.

I'm 100% sure I accidentally implemented this wrong for two children nodes — should fix. Algorithm should be something like:

find node to delete
  if has two children
  _node := max in left subtree || min in right subtree
  swap values
  delete _node

https://github.com/Divyanshnigam/PEPCO/blob/master/Binary%20Search%20Tree/Largest_BST.cpp

Source of really hard to track down bugs.

Currently, all three tree implementations manage their own memory. Being containers, they copy in whatever object is passed to them. If this has, say, a string, with a pointer to the GC heap it may be reaped when its original reference goes out of scope, even though the tree holds on to it. Potential disaster. Of course this can be avoided by passing on