Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bfit bolditalic tex cmd #25359

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add bfit bolditalic tex cmd #25359

wants to merge 2 commits into from
+15 −3

Conversation

devRD
Copy link
Contributor

@devRD devRD commented Mar 1, 2023

PR Summary

Fixes #19393
Adds support for bfit command in mathtext for bold italic

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@anntzer
Copy link
Contributor

anntzer commented Mar 2, 2023

Is that only implemented for stix? Do dejavu & cm also need their own thing?

@devRD
Copy link
Contributor Author

devRD commented Mar 3, 2023

Looks like dejavu and cm require their own mappings.

rcomer
rcomer reviewed Mar 6, 2023
View changes
lib/matplotlib/tests/test_mathtext.py
@@ -151,6 +151,7 @@
(['mathrm'], all),
(['mathbf'], all),
(['mathit'], all),
(['mathbfit'], all),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment just above this list says “Add new tests at the end.” Looking at the failing tests themselves, it looks like the images are numbered according to the index in the list. So I think you just need to move your new entry to the end of the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcomer rcomer rcomer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
topic: text/mathtext
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

\bf\it in mathtext
3 participants
@devRD @anntzer @rcomer