Skip to content

Fix date_ticker_factory to handle small spans #17270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

leolchat
Copy link
Contributor

@leolchat leolchat commented Apr 30, 2020

When the span is less than a minute (some seconds or some microseconds), the function previously returned a MinuteLocator, when there is a SecondLocator and a MicrosecondLocator.

Note that this function is not tested nor used directly in the matplotlib package, and I am not using it directly anymore neither, but that is a simple fix I believe.

When the span is less than a minute (some seconds or some microseconds), the function previously returned a MinuteLocator,
when there is a SecondLocator and a MicrosecondLocator.
@jklymak
Copy link
Member

jklymak commented Apr 30, 2020

Hmmm, if its not used, suggest we deprecate it, not add logic?

@leolchat
Copy link
Contributor Author

Seems to provide something very similar to the AutoDateFormatter, so I guess yes it could/should be deprecated. I am not sure how to do that, feel free to edit my PR if that is helpful or to close it.

@QuLogic QuLogic added the status: needs comment/discussion needs consensus on next step label Sep 23, 2020
@jklymak jklymak marked this pull request as draft April 23, 2021 15:28
@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Jul 26, 2023
@dstansby
Copy link
Member

dstansby commented Jan 6, 2024

Looks like date_ticker_factory was removed in Matplotlib 3.8, so closing this PR. Thanks for opening though!

@dstansby dstansby closed this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: inactive Marked by the “Stale” Github Action status: needs comment/discussion needs consensus on next step status: needs rebase status: needs revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants