Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove some numpy function overrides from pylab #25384

Merged
merged 1 commit into from Mar 6, 2023

Conversation

greglucas
Copy link
Contributor

PR Summary

Numpy added round, max, min to their exported names which we don't want when we import * from Numpy.

xref: numpy/numpy#23302

closes #25379

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Numpy added round, max, min to their exported names which
we don't want when we import * from Numpy.
@greglucas greglucas added this to the v3.7.2 milestone Mar 4, 2023
rcomer
rcomer approved these changes Mar 5, 2023
@timhoffm timhoffm merged commit bdb4935 into matplotlib:main Mar 6, 2023
36 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 6, 2023
@greglucas greglucas deleted the np-import-builtins branch March 6, 2023 14:59
oscargus added a commit that referenced this pull request Mar 6, 2023
…384-on-v3.7.x

Backport PR #25384 on branch v3.7.x (FIX: Remove some numpy function overrides from pylab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TST] Upcoming dependency test failures
3 participants