DOC: remove default logo [ci doc] #25429
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
force-pushed
the
doc-more-logo-fix
branch
from
b514671
to
fdb5eaa
Compare
|
OK, the logos are correct now. |
jklymak
commented
Mar 10, 2023
| python -m pip install --user \ | ||
| numpy<< parameters.numpy_version >> codecov coverage \ | ||
| -r requirements/doc/doc-requirements.txt | ||
| python -m pip install --no-deps --user \ |
There was a problem hiding this comment.
mpl-sphinx-theme is in our requirements, and we are pinning it, so the git-install has to happen subsequent to the pin.
QuLogic
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR Summary
#25423 didn't quite get th logo correct, in particular the dark logo was not being used in dark mode. I'm not sure what caused this, because it works fine in mpl-sphinx-theme, but mpl-sphinx-theme doesn't set
html-logoso let's try removing that.PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst