Skip to content

ci: Install pytz for Pandas nightly wheel #25434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 11, 2023

PR Summary

At some point, one of our dependencies must have required pytz, but then recently dropped it. Pandas also requires it, but because we install the nightly wheels using --index-url, pip can only install files from that index, which does not contain pytz. And we want to use that index exclusively because we only want the nightly wheels, and nothing else. So explicitly install pytz when running nightlies.

Also, make -i into the more explicit --index-url, and word-wrap that step.

Fixes #25431

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

At some point, one of our dependencies must have required `pytz`, but
then recently dropped it. Pandas also requires it, but because we
install the nightly wheels using `--index-url`, `pip` can only install
files from that index, which does not contain `pytz`. And we want to use
that index exclusively because we only want the nightly wheels, and
nothing else.

Also, make `-i` into the more explicit `--index-url`, and word-wrap that
step.

Fixes matplotlib#25431
@QuLogic QuLogic added Maintenance CI: testing CI configuration and testing labels Mar 11, 2023
@QuLogic QuLogic added this to the v3.8.0 milestone Mar 11, 2023
@oscargus oscargus merged commit 73394f2 into matplotlib:main Mar 12, 2023
@QuLogic QuLogic deleted the pandas-pytz branch March 13, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: testing CI configuration and testing Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TST] Upcoming dependency test failures
3 participants