Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Make ConstraintValidatorTestCase compatible with PHPUnit 10 #49220

Merged
merged 1 commit into from Feb 4, 2023

Conversation

gjuric
Copy link
Contributor

@gjuric gjuric commented Feb 3, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #49218
License MIT

As explained in #49218 MockBuilder::setMethods() has been removed from PHPUnit 10 and replaced with MockBuilder::onlyMethods(). This change checks if onlyMethods() is defined and if not falls back to old version that uses setMethods().

@carsonbot carsonbot changed the title Make ConstraintValidatorTestCase compatible with PHPUnit 10 [Validator] Make ConstraintValidatorTestCase compatible with PHPUnit 10 Feb 3, 2023
xabbuh
xabbuh approved these changes Feb 3, 2023
fabpot
fabpot approved these changes Feb 4, 2023
@fabpot
Copy link
Member

fabpot commented Feb 4, 2023

Thank you @gjuric.

@fabpot fabpot merged commit e53785b into symfony:5.4 Feb 4, 2023
5 of 11 checks passed
This was referenced Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants