[Workflow] display label with new lines + colours properly when rendering a PUML dump #49516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
force-pushed
the
5.4-fix-style-of-label-containing-new-lines-in-puml-dump
branch
from
a3edf88
to
c363a64
Compare
lyrixx
reviewed
Feb 23, 2023
src/Symfony/Component/Workflow/Tests/fixtures/puml/arrow/complex-state-machine-marking.puml
Show resolved
Hide resolved
lyrixx
reviewed
Feb 23, 2023
alexislefebvre
force-pushed
the
5.4-fix-style-of-label-containing-new-lines-in-puml-dump
branch
from
c363a64
to
d0da385
Compare
lyrixx
approved these changes
Feb 23, 2023
alexislefebvre
commented
Feb 23, 2023
alexislefebvre
changed the title
alexislefebvre
changed the title
carsonbot
changed the title
nicolas-grekas
force-pushed
the
5.4-fix-style-of-label-containing-new-lines-in-puml-dump
branch
from
d0da385
to
361dce2
Compare
|
Thank you @alexislefebvre. |
alexislefebvre
deleted the
5.4-fix-style-of-label-containing-new-lines-in-puml-dump
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In #49272 I removed the new lines instead of formatting them properly.
The PUML format accept new lines in labels of transitions as long as the source file uses actual
\nstrings instead of line returns (likePHP_EOL).I propose a novel approach that will handle new lines with or without colours.
Compare these outputs from plantuml.com, inputs are based on the fixtures from Symfony:
After #49272
New lines are ignored
(source)
Correct output from this PR
With this patch → the second line is Grey and no tag is visible
(source)
Why close and open
<font>tags?The output is broken if we use
\nwithout taking into account the<font>tags → there is a second line but it is black and</font>is visible(source)