Dockerizing the pythondotorg codebase: #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
reviewed
Aug 24, 2022
ewdurbin
requested changes
Aug 25, 2022
ewdurbin
reviewed
Aug 25, 2022
This is working splendidly! Thank you!
Three things I think we should add to wrap this up, that represent common developer patterns:
make migrationswhich should call the Djangomakemigrationsmanagement command.make migratewhich should call the Djangomigratecommand independently of the db initialization, we should refactor the initialization target to run this instead of duplicating the call tomanage.py migratebetween them.make shellwhich drops a developer into a Django shell via theshellmanagement command.
As a stretch goal, a make manage target that accepts arbitrary arguments after the manage and runs manage.py inside the container with those arguments would be very helpful!
ewdurbin
approved these changes
Aug 26, 2022
|
Let's address the changes noted above and this is good from a technical perspective. We probably want to add some docs to https://github.com/python/pythondotorg/blob/main/docs/source/install.rst with how to get setup using docker/docker-compose. |
This commit will add the appropriate Dockerfile and docker-compose.yml file to begin the process of dockerizing the pythondotorg codebase. Next steps include completeing a Makefile.
…ause a health check is already configured.
…b-initialized when needed.
cegerhardson
force-pushed
the
dockerize_pythondotorg_codebase
branch
from
75f52cc
to
9e113fc
Compare
ewdurbin
reviewed
Aug 29, 2022
|
Thank you @cegerhardson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This commit will add the appropriate Dockerfile and docker-compose.yml file to begin the process of dockerizing the pythondotorg codebase.
Next steps include completeing a Makefile.