New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerizing the pythondotorg codebase: #2130
Dockerizing the pythondotorg codebase: #2130
Conversation
This is working splendidly! Thank you!
Three things I think we should add to wrap this up, that represent common developer patterns:
make migrations
which should call the Djangomakemigrations
management command.make migrate
which should call the Djangomigrate
command independently of the db initialization, we should refactor the initialization target to run this instead of duplicating the call tomanage.py migrate
between them.make shell
which drops a developer into a Django shell via theshell
management command.
As a stretch goal, a make manage
target that accepts arbitrary arguments after the manage and runs manage.py
inside the container with those arguments would be very helpful!
Let's address the changes noted above and this is good from a technical perspective. We probably want to add some docs to https://github.com/python/pythondotorg/blob/main/docs/source/install.rst with how to get setup using docker/docker-compose. |
This commit will add the appropriate Dockerfile and docker-compose.yml file to begin the process of dockerizing the pythondotorg codebase. Next steps include completeing a Makefile.
…ause a health check is already configured.
…b-initialized when needed.
75f52cc
to
9e113fc
Compare
Thank you @cegerhardson! |
This commit will add the appropriate Dockerfile and docker-compose.yml file to begin the process of dockerizing the pythondotorg codebase.
Next steps include completeing a Makefile.