Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CleanPath instead of path.Clean (#23371) #23442

Open
wants to merge 1 commit into
base: release/v1.19
Choose a base branch
from
Open

Use CleanPath instead of path.Clean (#23371) #23442

wants to merge 1 commit into from
+40 −23

Conversation

wolfogre
Copy link
Member

Backport #23371.

As title.

lunny
lunny approved these changes Mar 13, 2023
View changes
@lunny lunny added this to the 1.19.0 milestone Mar 13, 2023
zeripath
zeripath requested changes Mar 13, 2023
View changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many issues with this PR - it will result in paths that previously could not have an initial "/" to now possibly have a preceding "/"

This is very likely to introduce several bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeripath zeripath zeripath requested changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
kind/refactor lgtm/need 1
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wolfogre @lunny @zeripath @GiteaBot