[Tests] Remove occurrences of withConsecutive()
#49621
Merged
+796
∄1�7365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
requested review from
wouterj,
chalasr,
dunglas and
jderusse
as code owners
alexandre-daubois
force-pushed
the
with-consecutive
branch
from
371f81a
to
b80140c
Compare
nicolas-grekas
reviewed
Mar 6, 2023
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Tests/Transport/ConnectionTest.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
with-consecutive
branch
2 times, most recently
from
88faccd
to
0c2a960
Compare
nicolas-grekas
reviewed
Mar 6, 2023
src/Symfony/Bundle/FrameworkBundle/Tests/Console/ApplicationTest.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
with-consecutive
branch
7 times, most recently
from
20b2aad
to
dec056f
Compare
|
|
alexandre-daubois
force-pushed
the
with-consecutive
branch
4 times, most recently
from
f073856
to
0487116
Compare
rmikalkenas
reviewed
Mar 9, 2023
nicolas-grekas
reviewed
Mar 9, 2023
src/Symfony/Component/HttpKernel/Tests/EventListener/LocaleAwareListenerTest.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
with-consecutive
branch
5 times, most recently
from
54e9ccf
to
b669243
Compare
alexandre-daubois
force-pushed
the
with-consecutive
branch
4 times, most recently
from
defe8e2
to
834ac75
Compare
nicolas-grekas
reviewed
Mar 10, 2023
src/Symfony/Component/Notifier/Tests/Event/FailedMessageEventTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
reviewed
Mar 10, 2023
nicolas-grekas
force-pushed
the
with-consecutive
branch
3 times, most recently
from
2ef12d5
to
bf2fcfa
Compare
nicolas-grekas
force-pushed
the
with-consecutive
branch
from
bf2fcfa
to
2047763
Compare
|
Thank you @alexandre-daubois. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 10, 2023
…xandre-daubois) This PR was merged into the 6.2 branch. Discussion ---------- [Tests] Remove `withConsecutive()` calls from tests | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | _NA_ | License | MIT | Doc PR | _NA_ Follows-up #49621ℹ️ No more `setMethods()` deprecated calls have been found in 6.2. Commits ------- 6b27e78 [Tests] Remove `withConsecutive()` calls from tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
withConsecutive()has been deprecated in PHPUnit 9.6 and removed in PHP 10 (sebastianbergmann/phpunit#4564). This PR aims at starting the work to remove these occurrences. There is unfortunately no given migration path, and this requires manual work.I'll create a meta issue referencing remaining occurrences if this one's merged, to keep track. Some seems pretty hard to remove.
cc @OskarStark this might interest you, as we worked a lot on tests lately😄