tests: add basic type checking with mypy #756
Merged
+27
−4
Conversation
|
Nice! |
xginn8
force-pushed the
xginn8:736-mypy-typings
branch
2 times, most recently
from
b2ba263
to
92ba134
|
@aviau tests are now passing, PTAL as I'm new to |
|
LGTM! The rest should be done in other PRs, type stuff as we go. I have mypy experience so let me know if you guys have questions while typing stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Closes #736
Contributor checklist