[HttpClient] Add ServerSentEvent::getArrayData() to get the SSE's data decoded as an array directly #49798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
http-client/sse-get-array-data
branch
from
2cbd019 to
b162761
Compare
fancyweb
force-pushed
the
http-client/sse-get-array-data
branch
from
b162761 to
042aa02
Compare
src/Symfony/Component/HttpClient/Tests/Chunk/ServerSentEventTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Mar 29, 2023
…a decoded as an array directly
fancyweb
force-pushed
the
http-client/sse-get-array-data
branch
from
042aa02 to
cdbf939
Compare
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the data field in SSEs can be "anything", it's really common that it's a JSON payload.
Just like we have a shortcut in responses (
ResponseInterface::toArray()), I think it's worth having a shortcut inServerSentEventto avoid writing boilerplate code again and again 😅