Skip to content

Change documentation return type of PrivateKey::RSA.from_openssl #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

Change documentation return type of PrivateKey::RSA.from_openssl #50

merged 1 commit into from
Mar 30, 2023

Conversation

jshawl
Copy link
Contributor

@jshawl jshawl commented Mar 29, 2023

This PR updates the documentation comment to return an OpenSSL::PKey::RSA instance instead of OpenSSL::PKey::DSA

@jshawl
Change return type of PrivateKey::RSA.from_openssl
612f1ab 
This PR updates the documentation comment to return an `OpenSSL::PKey::RSA` instance instead of `OpenSSL::PKey::DSA`
@vcsjones vcsjones merged commit 997af7f into github:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcsjones vcsjones vcsjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jshawl @vcsjones