feat(core): Provide a diagnostic for missing Signal invocation in template interpolation. #49660
+204
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
feat/signal-call-templatecheck
branch
from
b26ac14
to
a40e89f
Compare
…plate interpolation. To improve DX for beginners, this commit ads an extended diagnostic for Signals in template interpolations.
JeanMeche
force-pushed
the
feat/signal-call-templatecheck
branch
from
a40e89f
to
e88232a
Compare
|
This sounds like a great idea for a template diagnostic! Looking forward to it being ready for review/discussion! |
dylhunn
added
area: compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
To improve DX for beginners, this commit ads an extended diagnostic for Signals in template interpolations.
See #49657
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?