Skip to content

Remove deprecated CompilerOptions.useJit andCompilerOptions.missingTranslation properties #49672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove deprecated CompilerOptions.useJit andCompilerOptions.missingTranslation properties #49672

wants to merge 2 commits into from

Conversation

JeanMeche
Copy link
Member

useJit and missingTranslation properties have been deprecated since v13 and are unused in Ivy. They can be safely removed.

Migration is provided to handle the breaking changes.

Does this PR introduce a breaking change?

  • Yes

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 2, 2023
@JeanMeche JeanMeche force-pushed the chore/deprecate-compiler-options branch 4 times, most recently from 4c13f03 to 0803d15 Compare April 2, 2023 20:11
@JeanMeche JeanMeche marked this pull request as ready for review April 2, 2023 20:36
@pullapprove pullapprove bot requested review from alxhub and AndrewKushnir April 2, 2023 20:36
@dylhunn dylhunn added area: compiler Issues related to `ngc`, Angular's template compiler compiler: jit labels Apr 4, 2023
@ngbot ngbot bot modified the milestone: Backlog Apr 4, 2023
@AndrewKushnir AndrewKushnir modified the milestones: Backlog, v17-candidates Apr 6, 2023
@JeanMeche JeanMeche closed this May 8, 2023
@JeanMeche JeanMeche deleted the chore/deprecate-compiler-options branch May 8, 2023 18:11
@JeanMeche JeanMeche restored the chore/deprecate-compiler-options branch May 8, 2023 18:11
@JeanMeche JeanMeche reopened this May 8, 2023
@alxhub alxhub self-assigned this Jun 12, 2023
alxhub
alxhub approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@pullapprove pullapprove bot requested review from alxhub and dylhunn June 12, 2023 23:06
@alxhub
Copy link
Member

alxhub commented Jun 12, 2023

Marking as blocked for now (until we're in the merge window for v17).

dylhunn
dylhunn approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core, fw-migrations, public-api

@pullapprove pullapprove bot requested a review from jessicajaniuk June 12, 2023 23:14
jessicajaniuk
jessicajaniuk approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@alxhub alxhub added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels Oct 5, 2023
@ngbot
Copy link

ngbot bot commented Oct 5, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure conflicts with base branch "main"
    failure status "ci/circleci: setup" is failing
    failure status "google-internal-tests" is failing
    pending missing required labels: target: *
    pending missing required status "ci/circleci: build"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alxhub
Copy link
Member

alxhub commented Oct 5, 2023

@JeanMeche if we can rebase this, it can land in v17 :D

@JeanMeche JeanMeche force-pushed the chore/deprecate-compiler-options branch from 0803d15 to 0bb949e Compare October 5, 2023 17:11
@angular-robot angular-robot bot requested a review from jessicajaniuk October 5, 2023 17:11
@JeanMeche JeanMeche mentioned this pull request Oct 5, 2023
Closed
@JeanMeche JeanMeche force-pushed the chore/deprecate-compiler-options branch from 0bb949e to f79a076 Compare October 5, 2023 23:29
@JeanMeche
feat(core): Remove deprecated CompilerOptions.useJit and`CompilerOp…
d1b20aa 
…tions.missingTranslation`.

Both properties have been deprecated in v13 and are unused in v16.
@JeanMeche
feat(migrations): schematic to remove deprecated CompilerOptions prop…
9d5d12e 
…erties

`useJit` and `missingTranslation` have been deprecated since v13 and  are unused in Ivy. They can be safely removed.
@JeanMeche JeanMeche force-pushed the chore/deprecate-compiler-options branch from f79a076 to 9d5d12e Compare October 5, 2023 23:33
@atscott atscott added the target: major This PR is targeted for the next major release label Oct 10, 2023
@atscott
Copy link
Contributor

atscott commented Oct 10, 2023

This PR was merged into the repository by commit f0da7c2.

@atscott atscott closed this in 40113f6 Oct 10, 2023
atscott pushed a commit that referenced this pull request Oct 10, 2023
@JeanMeche @atscott
feat(migrations): schematic to remove deprecated CompilerOptions prop…
f0da7c2 
…erties (#49672)

`useJit` and `missingTranslation` have been deprecated since v13 and  are unused in Ivy. They can be safely removed.

PR Close #49672
alxhub added a commit to alxhub/angular that referenced this pull request Oct 10, 2023
@alxhub
fix(core): remove unnecessary migration
2075082 
PR angular#49672 added a g3-flavored migration for compiler option removal, but g3
doesn't use those options at all. So this migration is unnecessary and we
can remove it.
@alxhub alxhub mentioned this pull request Oct 10, 2023
Closed
angular-robot bot pushed a commit that referenced this pull request Oct 10, 2023
@alxhub @atscott
fix(core): remove unnecessary migration (#52141)
4da08dc 
PR #49672 added a g3-flavored migration for compiler option removal, but g3
doesn't use those options at all. So this migration is unnecessary and we
can remove it.

PR Close #52141
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@JeanMeche @ChellappanRajan
feat(core): Remove deprecated CompilerOptions.useJit and`CompilerOp…
ef23b76 
…tions.missingTranslation`. (angular#49672)

Both properties have been deprecated in v13 and are unused in v16.

PR Close angular#49672
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@JeanMeche @ChellappanRajan
feat(migrations): schematic to remove deprecated CompilerOptions prop…
63d12cd 
…erties (angular#49672)

`useJit` and `missingTranslation` have been deprecated since v13 and  are unused in Ivy. They can be safely removed.

PR Close angular#49672
@JeanMeche JeanMeche deleted the chore/deprecate-compiler-options branch February 29, 2024 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxhub alxhub alxhub approved these changes

@dylhunn dylhunn dylhunn approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees

@alxhub alxhub

Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler breaking changes compiler: jit detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v17-candidates
Development

Successfully merging this pull request may close these issues.
7 participants
@JeanMeche @alxhub @atscott @dylhunn @jessicajaniuk @JoostK @AndrewKushnir