Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96678: Avoid undefined behaviour in test #96672

Merged
merged 5 commits into from Sep 13, 2022
Merged

gh-96678: Avoid undefined behaviour in test #96672

merged 5 commits into from Sep 13, 2022

Conversation

matthiasgoergens
Copy link
Contributor

@matthiasgoergens matthiasgoergens commented Sep 8, 2022 •
edited by bedevere-bot

Signed integer overflow is undefined behaviour.

@matthiasgoergens matthiasgoergens mentioned this pull request Sep 8, 2022
Closed
@matthiasgoergens matthiasgoergens changed the title no-issue: Avoid undefined behaviour in test gh-96678: Avoid undefined behaviour in test Sep 8, 2022
@matthiasgoergens
Copy link
Contributor Author

matthiasgoergens commented Sep 13, 2022

@pablogsal Would you like to have a look, please? Thanks!

@pablogsal pablogsal merged commit 6ba686d into python:main Sep 13, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 13, 2022

Thanks @matthiasgoergens for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 13, 2022

Sorry @matthiasgoergens and @pablogsal, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6ba686d97fd6d2a2169696c6629f7de9482f52db 3.11

@miss-islington
Copy link
Contributor

miss-islington commented Sep 13, 2022

Sorry, @matthiasgoergens and @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6ba686d97fd6d2a2169696c6629f7de9482f52db 3.10

@pablogsal
Copy link
Member

pablogsal commented Sep 13, 2022

Could you do the backports using cherry_picker @matthiasgoergens ?

@miss-islington
Copy link
Contributor

miss-islington commented Sep 13, 2022

Thanks @matthiasgoergens for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 13, 2022

Sorry @matthiasgoergens and @pablogsal, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6ba686d97fd6d2a2169696c6629f7de9482f52db 3.11

@matthiasgoergens
Copy link
Contributor Author

matthiasgoergens commented Sep 13, 2022

Ok. I'll use cherry_picker later. I'm not on my PC right now.

@miss-islington
Copy link
Contributor

miss-islington commented Sep 13, 2022

Thanks @matthiasgoergens for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 13, 2022
@matthiasgoergens @miss-islington
pythongh-96678: Avoid undefined behaviour in test (pythonGH-96672)
b570747 
(cherry picked from commit 6ba686d)

Co-authored-by: Matthias Görgens <matthias.goergens@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Sep 13, 2022

GH-96795 is a backport of this pull request to the 3.11 branch.

pablogsal pushed a commit that referenced this issue Sep 13, 2022
@miss-islington @matthiasgoergens
gh-96678: Avoid undefined behaviour in test (GH-96672) (#96795)
cc8b006 
(cherry picked from commit 6ba686d)

Co-authored-by: Matthias Görgens <matthias.goergens@gmail.com>

Co-authored-by: Matthias Görgens <matthias.goergens@gmail.com>
@matthiasgoergens
Copy link
Contributor Author

matthiasgoergens commented Sep 14, 2022

@pablogsal Sorry, I was a bit late. Does this still need the backport?

@matthiasgoergens matthiasgoergens deleted the matthias/avoid-ub-in-test branch Sep 14, 2022
@pablogsal
Copy link
Member

pablogsal commented Sep 14, 2022

I think we are still missing the 3.10 backport

@matthiasgoergens
Copy link
Contributor Author

matthiasgoergens commented Sep 14, 2022

Oh, I was confused about 3.11 vs 3.10 backport. Yes, I see know that the 3.10 one is still missing.

@matthiasgoergens
Copy link
Contributor Author

matthiasgoergens commented Sep 18, 2022

@pablogsal Actually, since we are not going to drop -fwrapv for anything below 3.12, we don't need to backport this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees

@pablogsal pablogsal

Labels
needs backport to 3.10 skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@matthiasgoergens @miss-islington @pablogsal @bedevere-bot @kumaraditya303 @AlexWaygood