🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit bb4062a 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

FYI, the failing buildbot are also failing on main; they are unrelated to this PR.

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 731dfc5 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

I'm going to merge this in a day or two.

The buildbot failures are unrelated to this PR.

rowcount's type should also be changed.
Otherwise on 32-bit big-endian platform, it will always be 0.

-{"rowcount", T_LONG,     offsetof(pysqlite_Cursor, rowcount), READONLY},
+{"rowcount", T_LONGLONG, offsetof(pysqlite_Cursor, rowcount), READONLY},

lastrowid's type is T_OBJECT, an int object is generated even if the user doesn't access it. we can keep it as integer type. But if access it multiple times, it will be slower.
Of course, this is another issue.

rowcount's type should also be changed. Otherwise on 32-bit big-endian platform, it will always be 0.

Good catch! long long is guaranteed to be at least 64 bits.

How about only apply 64-bit function to 3.12 branch? It's more or less a new feature.

I'm fine with backporting that, but I'll remove it from this PR nonetheless. It makes the PR cleaner.

These logical branches can be refactored for 3.12 branch.

Yes, we could do a lot of refactoring in the whole sqlite3 module. I prefer to keep refactorings in separate PRs.

Thanks for reviewing!

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 0ebf8a8 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

FTR, buildbot failures are unrelated to this PR.

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

GH-93598 is a backport of this pull request to the 3.11 branch.

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 875de61c296604f3a3a51e9d76355e0f1a24c6af 3.10

GH-93599 is a backport of this pull request to the 3.10 branch.