Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility Jython code #99482

Open
1 task
sobolevn opened this issue Nov 14, 2022 · 3 comments
Open
1 task

Remove compatibility Jython code #99482

sobolevn opened this issue Nov 14, 2022 · 3 comments
Assignees
Labels
type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Nov 14, 2022

There are several places where some Jython-specific hacks are used. For example, there are imports from com.python.core which is a third-party library.

They are untested and undocumented.

Right now Jython is stuck with 2.7
I think, we don't have to keep it: eventually Jython can patch it on their side, since all parts are pure-Python code.

Original issue on Jython's repo: jython/jython#217

I think we should leave this open for some time (1 month?) to let Jython's team to comment on this.

CC @Yhg1s

PR to review and comment is incoming :)

@sobolevn sobolevn added the type-bug An unexpected behavior, bug, or error label Nov 14, 2022
@vstinner
Copy link
Member

vstinner commented Nov 14, 2022

PyPy has patches on top of CPython stdlib. They fork the stdlib. I would prefer to avoid "downstream patches", but I don't recall any attempt from PyPy to merge these changes in CPython upstream.

IMO it's ok if Jython also has "downstream patches" on top of CPython stdlib. I expect that they need a few changes to better integrate the stdlib with Jython, optimize the code, give access to Jython features, etc.

Sadly yes, Jython seems inactive and I also would prefer to not continue maintaining code which is specific to Jython if nobody recalls where it comes from, if it's not tested, etc.

@sobolevn sobolevn self-assigned this Nov 14, 2022
@sobolevn
Copy link
Member Author

sobolevn commented Nov 14, 2022

There's also https://docs.python.org/3/library/platform.html#java-platform
But, I don't think we can touch it, since it is a public API: not specific to Jython. Others might use it as well.

But, this can be deprecated after further usage analysis.

@sobolevn
Copy link
Member Author

sobolevn commented Nov 14, 2022

Citing Jython team:

tl;dr: It's fine to remove from 3.x; I assume you have no interest in doing so from 2.7.

Link: jython/jython#217 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants